Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2611703002: The DOMRectReadOnly interface requires serializer. (Closed)

Created:
3 years, 11 months ago by Byoungkwon Ko
Modified:
3 years, 11 months ago
Reviewers:
haraken, zino
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The DOMRectReadOnly interface requires serializer. The DOMRectReadOnly interface requires serializer. The DOMRectReadOnly implementation is different with spec. It should match up with the spec[1]. [1] https://drafts.fxtf.org/geometry/#domrectreadonly BUG=678023 Review-Url: https://codereview.chromium.org/2611703002 Cr-Commit-Position: refs/heads/master@{#442164} Committed: https://chromium.googlesource.com/chromium/src/+/1973750ff59aedf91e56ac03754673d22f8f11de

Patch Set 1 #

Patch Set 2 : DOMRectReadOnly interface requires serializer. #

Patch Set 3 : DOMRectReadOnly interface requires serializer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-rect.html View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMRectReadOnly.h View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMRectReadOnly.cpp View 1 2 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMRectReadOnly.idl View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Byoungkwon Ko
PTAL
3 years, 11 months ago (2017-01-05 14:59:23 UTC) #4
Byoungkwon Ko
PTAL
3 years, 11 months ago (2017-01-05 14:59:25 UTC) #5
zino
On 2017/01/05 14:59:25, Byoungkwon Ko wrote: > PTAL lgtm but please fix a typo in ...
3 years, 11 months ago (2017-01-06 20:24:51 UTC) #6
Byoungkwon Ko
PTAL
3 years, 11 months ago (2017-01-07 08:01:02 UTC) #9
haraken
LGTM
3 years, 11 months ago (2017-01-07 09:39:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611703002/40001
3 years, 11 months ago (2017-01-07 12:03:14 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 13:17:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1973750ff59aedf91e56ac037546...

Powered by Google App Engine
This is Rietveld 408576698