Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2611593005: Revert of Fix TabCaptureApiTest.FullscreenEvents flakiness (Closed)

Created:
3 years, 11 months ago by samuong
Modified:
3 years, 11 months ago
Reviewers:
xjz, miu
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, extensions-reviews_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix TabCaptureApiTest.FullscreenEvents flakiness (patchset #2 id:20001 of https://codereview.chromium.org/2604133002/ ) Reason for revert: TabCaptureApiTest.FullscreenEvents is now timing out consistently on the Win7 Tests (dbg)(1) bot (build #56178 and later) so I don't think we're ready to re-enable it yet: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29 Original issue's description: > Fix TabCaptureApiTest.FullscreenEvents flakiness > > Fixes flakiness caused by a subtle distinction in document fullscreen > state change: The tabCapture.onStatusChanged API can sometimes report a > fullscreen state change before the document itself is aware the change > occurred. This is because the tabCapture API's listener reports on the > browser's fullscreen state, whereas the document is only aware of its > own internal fullscreen state (which is updated only after the browser > notifies it of a change). > > The flakiness was due to the C++ side of the test being notified that > the page had entered fullscreen before the page itself was aware of it. > This caused the simulated mouse click (to toggle fullscreen mode) to be > made early, and then both the C++ and JS sides of the test became > out-of-sync and froze, each waiting on the other to do something. > > This change fixes the issue by always using the document's fullscreen > change listeners, to ensure the out-of-sync condition cannot occur. > This change also "freshens up" the JavaScript code in this test, using > newer ES6 syntax. > > BUG=675851 > > Committed: https://crrev.com/c52ce18fd8f6db97c62737f0924bd61a2727c5d3 > Cr-Commit-Position: refs/heads/master@{#441252} TBR=xjz@chromium.org,miu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=675851 Committed: https://crrev.com/df9fdf81fa2e0b50372d6cad7333d6135501db24 Cr-Commit-Position: refs/heads/master@{#441307}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -60 lines) Patch
M chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/tab_capture/fullscreen_test.js View 1 chunk +31 lines, -59 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
samuong
Created Revert of Fix TabCaptureApiTest.FullscreenEvents flakiness
3 years, 11 months ago (2017-01-04 03:18:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611593005/1
3 years, 11 months ago (2017-01-04 03:18:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 03:19:50 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 03:24:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df9fdf81fa2e0b50372d6cad7333d6135501db24
Cr-Commit-Position: refs/heads/master@{#441307}

Powered by Google App Engine
This is Rietveld 408576698