Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2611593003: Modify and rebaseline popup menu web font loading test (Closed)

Created:
3 years, 11 months ago by adithyas
Modified:
3 years, 11 months ago
Reviewers:
jbroman
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify and rebaseline popup menu web font loading test The original image baseline has the dropdown options hovering above the selector. This moves the <select> above the description/console and makes the dropdown appear in the correct position (i.e. directly below the selector) BUG= Committed: https://crrev.com/0b6c7b4cbde9dfca90697813d1a7571a45da2a14 Cr-Commit-Position: refs/heads/master@{#441407}

Patch Set 1 #

Patch Set 2 : Rebaseline tests #

Messages

Total messages: 15 (10 generated)
adithyas
3 years, 11 months ago (2017-01-04 16:26:50 UTC) #7
jbroman
lgtm
3 years, 11 months ago (2017-01-04 17:30:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611593003/20001
3 years, 11 months ago (2017-01-04 17:59:00 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 18:03:30 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 18:05:12 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0b6c7b4cbde9dfca90697813d1a7571a45da2a14
Cr-Commit-Position: refs/heads/master@{#441407}

Powered by Google App Engine
This is Rietveld 408576698