Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2611583002: Move files for search geolocation into their own folder. (Closed)

Created:
3 years, 11 months ago by benwells
Modified:
3 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, mlamouri+watch-geolocation_chromium.org, Michael van Ouwerkerk, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move files for search geolocation into their own folder. This change also adds an OWNERS file for these files. TBR=sky, mvanouwerkerk BUG=674389 Committed: https://crrev.com/35f8ada78b86be36a83236aad2f39091cf744db5 Cr-Commit-Position: refs/heads/master@{#441329}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -536 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/preferences/browser_prefs_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/android/search_geolocation/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A + chrome/browser/android/search_geolocation/search_geolocation_disclosure_infobar_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/android/search_geolocation/search_geolocation_disclosure_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/android/search_geolocation_disclosure_infobar_delegate.h View 1 chunk +0 lines, -89 lines 0 comments Download
D chrome/browser/android/search_geolocation_disclosure_infobar_delegate.cc View 1 chunk +0 lines, -126 lines 0 comments Download
D chrome/browser/android/search_geolocation_disclosure_tab_helper.h View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/android/search_geolocation_disclosure_tab_helper.cc View 1 chunk +0 lines, -245 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/search_geolocation_disclosure_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (12 generated)
benwells
3 years, 11 months ago (2017-01-03 00:52:49 UTC) #6
gone
lgtm
3 years, 11 months ago (2017-01-03 18:31:13 UTC) #7
benwells
TBR mvanouwerkerk and sky for refactoring fallout
3 years, 11 months ago (2017-01-04 06:11:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611583002/20001
3 years, 11 months ago (2017-01-04 06:12:11 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 07:17:47 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/35f8ada78b86be36a83236aad2f39091cf744db5 Cr-Commit-Position: refs/heads/master@{#441329}
3 years, 11 months ago (2017-01-04 07:19:40 UTC) #18
sky
3 years, 11 months ago (2017-01-04 16:20:48 UTC) #19
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698