Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2611543002: Escape on bluetooth keyboard closes the views (Closed)

Created:
3 years, 11 months ago by gambard
Modified:
3 years, 11 months ago
Reviewers:
Olivier, lpromero
CC:
chromium-reviews, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Escape on bluetooth keyboard closes the views Hitting the escape key on the bluetooth keyboard closes the history and the reading list views. BUG=676994 Committed: https://crrev.com/58ad898ef55fa116c6b4a02387a68ac597cc28fe Cr-Commit-Position: refs/heads/master@{#441360}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -11 lines) Patch
M ios/chrome/browser/ui/history/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/history/history_panel_view_controller.mm View 2 chunks +14 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_view_controller.h View 2 chunks +4 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm View 1 1 chunk +1 line, -2 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_view_controller_container.mm View 1 4 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
gambard
PTAL.
3 years, 11 months ago (2017-01-04 11:42:39 UTC) #10
lpromero
lgtm
3 years, 11 months ago (2017-01-04 11:55:52 UTC) #11
Olivier
lgtm
3 years, 11 months ago (2017-01-04 12:32:42 UTC) #12
Olivier
lgtm lgtm
3 years, 11 months ago (2017-01-04 12:32:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611543002/20001
3 years, 11 months ago (2017-01-04 12:53:06 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 12:57:46 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 13:01:53 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/58ad898ef55fa116c6b4a02387a68ac597cc28fe
Cr-Commit-Position: refs/heads/master@{#441360}

Powered by Google App Engine
This is Rietveld 408576698