Use TaskScheduler instead of WorkerPool in url_data_manager_backend.cc.

Use TaskScheduler instead of WorkerPool in url_data_manager_backend.cc.

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

Does Not Block (default):
  Tasks without the MayBlock() and WithBaseSyncPrimitives() traits
  may not block.

BUG=659191
Committed: https://crrev.com/39702ec4829b4889cc5400efb476e78d4f5eafaf
Cr-Commit-Position: refs/heads/master@{#441079}

[fdoray, 2016-12-31 21:20:55]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-31 21:21:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-31 21:31:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-31 21:31:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2017-01-01 19:30:57]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-01 19:31:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-01 20:19:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-01 20:19:17]

Dry run: This issue passed the CQ dry run.

[fdoray, 2017-01-01 23:16:29]

fdoray@chromium.org changed reviewers:
+ dbeam@chromium.org

[fdoray, 2017-01-01 23:16:29]

PTAL. WorkerPool is being deprecated in favor of TaskScheduler.

[Dan Beam, 2017-01-02 19:55:22]

lgtm

https://codereview.chromium.org/2611443002/diff/20001/content/browser/webui/u...
File content/browser/webui/url_data_manager_backend.cc (right):

https://codereview.chromium.org/2611443002/diff/20001/content/browser/webui/u...
content/browser/webui/url_data_manager_backend.cc:483:
base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN),
i don't know how easy it is to do, but it'd be nice to up the priority on these
tasks when the tab in is the foreground.  as in: WithPriority(USER_BLOCKING)

[fdoray, 2017-01-02 19:58:28]

https://codereview.chromium.org/2611443002/diff/20001/content/browser/webui/u...
File content/browser/webui/url_data_manager_backend.cc (right):

https://codereview.chromium.org/2611443002/diff/20001/content/browser/webui/u...
content/browser/webui/url_data_manager_backend.cc:483:
base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN),
On 2017/01/02 19:55:22, Dan Beam wrote:
> i don't know how easy it is to do, but it'd be nice to up the priority on
these
> tasks when the tab in is the foreground.  as in: WithPriority(USER_BLOCKING)

We have plan to add a context trait. There will be a context for each tab. It
will be possible to dynamically change the priority of all tasks for a given
context. I took a note to add the context trait to this task once we implement
it.

[fdoray, 2017-01-02 19:58:34]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-01-02 19:58:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-02 21:08:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483387114230740,
"parent_rev": "b03f3626c4e750aeed5323617472e34b2209abf1", "commit_rev":
"5f1400c83de829c61dba855d0fac49addcfc16ac"}

[commit-bot: I haz the power, 2017-01-02 21:09:02]

Description was changed from

==========
Use TaskScheduler instead of WorkerPool in url_data_manager_backend.cc.

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

Does Not Block (default):
  Tasks without the MayBlock() and WithBaseSyncPrimitives() traits
  may not block.

BUG=659191
==========

to

==========
Use TaskScheduler instead of WorkerPool in url_data_manager_backend.cc.

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

Does Not Block (default):
  Tasks without the MayBlock() and WithBaseSyncPrimitives() traits
  may not block.

BUG=659191

Review-Url: https://codereview.chromium.org/2611443002
==========

[commit-bot: I haz the power, 2017-01-02 21:09:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-02 21:11:15]

Description was changed from

==========
Use TaskScheduler instead of WorkerPool in url_data_manager_backend.cc.

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

Does Not Block (default):
  Tasks without the MayBlock() and WithBaseSyncPrimitives() traits
  may not block.

BUG=659191

Review-Url: https://codereview.chromium.org/2611443002
==========

to

==========
Use TaskScheduler instead of WorkerPool in url_data_manager_backend.cc.

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

Does Not Block (default):
  Tasks without the MayBlock() and WithBaseSyncPrimitives() traits
  may not block.

BUG=659191

Committed: https://crrev.com/39702ec4829b4889cc5400efb476e78d4f5eafaf
Cr-Commit-Position: refs/heads/master@{#441079}
==========

[commit-bot: I haz the power, 2017-01-02 21:11:15]

Patchset 2 (id:??) landed as
https://crrev.com/39702ec4829b4889cc5400efb476e78d4f5eafaf
Cr-Commit-Position: refs/heads/master@{#441079}