Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2611433002: Use TaskScheduler instead of WorkerPool in timezone_settings.cc. (Closed)

Created:
3 years, 11 months ago by fdoray
Modified:
3 years, 11 months ago
Reviewers:
oshima, zel
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler instead of WorkerPool in timezone_settings.cc. The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Review-Url: https://codereview.chromium.org/2611433002 Cr-Commit-Position: refs/heads/master@{#444240} Committed: https://chromium.googlesource.com/chromium/src/+/8ffd7f1c09ec056e0aee132e95b40df60f5ff821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chromeos/settings/timezone_settings.cc View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
fdoray
PTAL. WorkerPool is being deprecated in favor of TaskScheduler.
3 years, 11 months ago (2017-01-01 19:13:54 UTC) #6
fdoray
On 2017/01/01 19:13:54, fdoray wrote: > PTAL. WorkerPool is being deprecated in favor of TaskScheduler. ...
3 years, 11 months ago (2017-01-10 19:43:47 UTC) #7
fdoray
+oshima@: PTAL (no reply from zel after 1 week)
3 years, 11 months ago (2017-01-13 18:54:00 UTC) #9
oshima
lgtm
3 years, 11 months ago (2017-01-18 01:22:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611433002/1
3 years, 11 months ago (2017-01-18 01:26:21 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 02:01:35 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8ffd7f1c09ec056e0aee132e95b4...

Powered by Google App Engine
This is Rietveld 408576698