Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2611413002: Remove CFX_ArrayTemplate from fpdfapi (Closed)

Created:
3 years, 11 months ago by Tom Sepez
Modified:
3 years, 11 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -188 lines) Patch
M core/fpdfapi/edit/cpdf_creator.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M core/fpdfapi/edit/fpdf_edit_create.cpp View 11 chunks +40 lines, -67 lines 0 comments Download
M core/fpdfapi/font/cpdf_cidfont.h View 3 chunks +4 lines, -3 lines 0 comments Download
M core/fpdfapi/font/cpdf_cidfont.cpp View 9 chunks +21 lines, -21 lines 0 comments Download
M core/fpdfapi/font/font_int.h View 2 chunks +2 lines, -1 line 0 comments Download
M core/fpdfapi/font/fpdf_font_cid.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfapi/parser/cpdf_data_avail.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/parser/cpdf_data_avail.cpp View 9 chunks +27 lines, -34 lines 0 comments Download
M core/fpdfapi/parser/cpdf_document.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_document.cpp View 11 chunks +19 lines, -25 lines 0 comments Download
M core/fpdfapi/parser/cpdf_document_unittest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/render/cpdf_rendercontext.h View 3 chunks +5 lines, -3 lines 0 comments Download
M core/fpdfapi/render/cpdf_rendercontext.cpp View 3 chunks +12 lines, -14 lines 0 comments Download
M core/fpdfapi/render/cpdf_renderstatus.h View 2 chunks +2 lines, -1 line 0 comments Download
M core/fpdfapi/render/cpdf_renderstatus.cpp View 4 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Dan, for review. https://codereview.chromium.org/2611413002/diff/1/core/fpdfapi/render/cpdf_renderstatus.cpp File core/fpdfapi/render/cpdf_renderstatus.cpp (right): https://codereview.chromium.org/2611413002/diff/1/core/fpdfapi/render/cpdf_renderstatus.cpp#newcode1853 core/fpdfapi/render/cpdf_renderstatus.cpp:1853: status.m_Type3FontCache = m_Type3FontCache; NOTE: for this ...
3 years, 11 months ago (2017-01-06 23:15:46 UTC) #6
dsinclair
lgtm
3 years, 11 months ago (2017-01-09 14:40:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611413002/20001
3 years, 11 months ago (2017-01-09 14:41:02 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 15:01:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/0fa471794a88b262f9114b973d74b1c33e4e...

Powered by Google App Engine
This is Rietveld 408576698