Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2611363002: [turbofan] Optimize strict equality with unique input. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize strict equality with unique input. If one input to JSStrictEqual/JSNotStrictEqual is Unique (except InternalizedString) or the hole, then we can turn that into a direct pointer comparison, as such values are only equal to exactly the same unique value. BUG=v8:5267 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2611363002 Cr-Commit-Position: refs/heads/master@{#42122} Committed: https://chromium.googlesource.com/v8/v8/+/b36b8395e81fa2f7709c27acec93e8ce26d5bc3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -20 lines) Patch
M src/compiler/js-typed-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +2 lines, -19 lines 0 comments Download
M src/compiler/types.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-06 19:11:44 UTC) #1
Jarin
lgtm
3 years, 11 months ago (2017-01-09 06:13:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611363002/1
3 years, 11 months ago (2017-01-09 06:13:26 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 06:40:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b36b8395e81fa2f7709c27acec93e8ce26d...

Powered by Google App Engine
This is Rietveld 408576698