Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2611293002: Do not use SpdyFrameBuilder::OverwriteLength(). (Closed)

Created:
3 years, 11 months ago by Bence
Modified:
3 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not use SpdyFrameBuilder::OverwriteLength(). Change SpdyFrameBuilder::BeginNewFrame() not to use OverwriteLength(). Proteced by FLAGS_chromium_http2_flag_remove_rewritelength. This CL lands server change 143445916 by yasong. BUG=488484 Review-Url: https://codereview.chromium.org/2611293002 Cr-Commit-Position: refs/heads/master@{#442931} Committed: https://chromium.googlesource.com/chromium/src/+/447bdcac0898c480cf2de6e32a663c8b895dfb8a

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -12 lines) Patch
M net/spdy/spdy_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_flags.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/spdy/spdy_frame_builder.h View 1 chunk +8 lines, -0 lines 0 comments Download
M net/spdy/spdy_frame_builder.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.cc View 6 chunks +52 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Bence
Ryan: PTAL. Thank you.
3 years, 11 months ago (2017-01-06 19:40:54 UTC) #6
Ryan Hamilton
lgtm
3 years, 11 months ago (2017-01-10 22:47:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611293002/20001
3 years, 11 months ago (2017-01-11 14:18:01 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/98152)
3 years, 11 months ago (2017-01-11 15:56:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611293002/20001
3 years, 11 months ago (2017-01-11 16:52:11 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 16:58:37 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/447bdcac0898c480cf2de6e32a66...

Powered by Google App Engine
This is Rietveld 408576698