Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2611283003: [ios] Moved ASSERT_TRUE out of block in WebStateTest.ScriptExecution. (Closed)

Created:
3 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Moved ASSERT_TRUE out of block in WebStateTest.ScriptExecution. ASSERT_TRUE stops test execution by retuning, which will not stop the test if return is called from the block. BUG=678942 Review-Url: https://codereview.chromium.org/2611283003 Cr-Commit-Position: refs/heads/master@{#442014} Committed: https://chromium.googlesource.com/chromium/src/+/7647e35b78ecf8f6ff9566728d7063760ec65ee4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M ios/web/web_state/web_state_impl_unittest.mm View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Eugene But (OOO till 7-30)
3 years, 11 months ago (2017-01-06 19:42:21 UTC) #6
rohitrao (ping after 24h)
lgtm, thanks! This could still potentially hang forever if the block never ran for some ...
3 years, 11 months ago (2017-01-06 19:45:19 UTC) #7
Eugene But (OOO till 7-30)
Thanks for quick review!
3 years, 11 months ago (2017-01-06 19:48:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611283003/1
3 years, 11 months ago (2017-01-06 19:49:08 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 19:54:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7647e35b78ecf8f6ff9566728d70...

Powered by Google App Engine
This is Rietveld 408576698