Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2611263002: Port gpu_process tests to gpu_integration_test harness. (Closed)

Created:
3 years, 11 months ago by Ken Russell (switch to Gerrit)
Modified:
3 years, 11 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, Kai Ninomiya, eyaich1, nednguyen, Julien Isorce Samsung
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port gpu_process tests to gpu_integration_test harness. The complexity of the old tests had gotten out of hand; Telemetry's benchmark infrastructure was not a good match for what were ideally imperative-style tests. These tests were ported one-by-one and tested along the way. They should be a 1:1 match in terms of functionality. In the new test harness, skip expectations work properly and don't run the test body on any platform, so some of the logic which avoided yielding certain tests on certain platforms has instead been expressed as test expectations. Delete the has_transparent_visuals_gpu_process and no_transparent_visuals_gpu_process tests, which had become no-ops. This is the last reference to the python code in content/test/gpu/page_sets. Delete it and the associated lint presubmit check. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org Review-Url: https://codereview.chromium.org/2611263002 Cr-Commit-Position: refs/heads/master@{#441887} Committed: https://chromium.googlesource.com/chromium/src/+/82a51d454bb51140c5c32b14d30361bbf5069d2d

Patch Set 1 #

Patch Set 2 : Added workaround for flakiness on Android. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+668 lines, -999 lines) Patch
M content/test/data/gpu/functional_3d_css.html View 2 chunks +9 lines, -3 lines 0 comments Download
M content/test/data/gpu/functional_canvas_demo.html View 1 chunk +3 lines, -1 line 0 comments Download
M content/test/data/gpu/functional_files/context.js View 2 chunks +11 lines, -3 lines 0 comments Download
M content/test/gpu/generate_buildbot_json.py View 2 chunks +8 lines, -8 lines 0 comments Download
D content/test/gpu/gpu_tests/gpu_process.py View 1 chunk +0 lines, -64 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_process_expectations.py View 1 chunk +15 lines, -17 lines 0 comments Download
A content/test/gpu/gpu_tests/gpu_process_integration_test.py View 1 1 chunk +528 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/lint_unittest.py View 1 chunk +0 lines, -6 lines 0 comments Download
D content/test/gpu/page_sets/__init__.py View 1 chunk +0 lines, -10 lines 0 comments Download
D content/test/gpu/page_sets/gpu_process_tests.py View 1 chunk +0 lines, -778 lines 0 comments Download
D content/test/gpu/page_sets/page_set_unittest.py View 1 chunk +0 lines, -15 lines 0 comments Download
M testing/buildbot/chromium.gpu.json View 8 chunks +16 lines, -16 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 39 chunks +78 lines, -78 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
Ken Russell (switch to Gerrit)
FYI. CQ'ing this TBR'd. I tested the port of this test locally on Mac, Linux ...
3 years, 11 months ago (2017-01-06 05:20:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611263002/20001
3 years, 11 months ago (2017-01-06 05:20:33 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 06:20:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/82a51d454bb51140c5c32b14d303...

Powered by Google App Engine
This is Rietveld 408576698