Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2611243002: MD Settings: fix policy indicator rendering bug in <controlled-button> (Closed)

Created:
3 years, 11 months ago by Dan Beam
Modified:
3 years, 11 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix policy indicator rendering bug in <controlled-button> A policy icon was being rendered when enforced, but without an icon to show. This wasn't a big deal as it was invisible and taking up empty space. But when flipping the position of this indicator, as in https://codereview.chromium.org/2615093003/, it visually matters. BUG=673953 R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2611243002 Cr-Commit-Position: refs/heads/master@{#441844} Committed: https://chromium.googlesource.com/chromium/src/+/069e4701f5dd4b6348938386afac502347832fe3

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -14 lines) Patch
M chrome/browser/resources/settings/controls/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/controls/controlled_button.html View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/controlled_button.js View 2 chunks +17 lines, -1 line 0 comments Download
M chrome/test/data/webui/settings/controlled_button_tests.js View 1 chunk +32 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Dan Beam
3 years, 11 months ago (2017-01-06 00:39:41 UTC) #5
dschuyler
lgtm
3 years, 11 months ago (2017-01-06 02:25:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611243002/60001
3 years, 11 months ago (2017-01-06 02:32:26 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 02:44:01 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/069e4701f5dd4b6348938386afac...

Powered by Google App Engine
This is Rietveld 408576698