Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2611233002: Reland of Don't paint underline or selections over ellipsis in mixed-flow contexts (Closed)

Created:
3 years, 11 months ago by rhogan
Modified:
3 years, 11 months ago
Reviewers:
loyso (OOO), eae, szager1
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Don't paint underline or selections over ellipsis in mixed-flow contexts (patchset #1 id:1 of https://codereview.chromium.org/2615843002/ ) Reason for revert: This patch was not the culprit for the layout test failures. Original issue's description: > Revert of Don't paint underline or selections over ellipsis in mixed-flow contexts (patchset #3 id:40001 of https://codereview.chromium.org/2594983002/ ) > > Reason for revert: > Causes test failures on Win10 Win7 bots: > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/18739 > > webkit_tests webkit_tests > > unexpected_failures: > fast/forms/select/menulist-appearance-basic.html > fast/forms/select/menulist-style-color.html > fast/forms/select/select-selected.html > fast/forms/select/menulist-width-change.html > fast/forms/select/option-text-clip.html > fast/forms/select/option-script.html > fast/forms/select/option-strip-whitespace.html > fast/forms/color/input-appearance-color.html > fast/forms/select/select-dirty-parent-pref-widths.html > fast/forms/select/select-initial-position.html > fast/forms/select/menulist-deselect-update.html > fast/forms/select/select-change-listbox-to-popup.html > fast/forms/select/select-background-none.html > fast/forms/select/menulist-update-text-popup.html > fast/forms/select/select-baseline.html > > Original issue's description: > > Don't paint underline or selections over ellipsis in mixed-flow contexts > > > > Also, ensure the selected text is painted correctly when an ellipsis is present > > in a mixed-flow context (e.g. ltr text in an rtl container). > > > > BUG=642454, 642450, 642460 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > > > Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4 > > Cr-Commit-Position: refs/heads/master@{#441486} > > TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=642454, 642450, 642460 > > Committed: https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d > Cr-Commit-Position: refs/heads/master@{#441599} TBR=eae@chromium.org,szager@chromium.org,loyso@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=642454, 642450, 642460 Review-Url: https://codereview.chromium.org/2611233002 Cr-Commit-Position: refs/heads/master@{#441775} Committed: https://chromium.googlesource.com/chromium/src/+/495d8354acfb5558725043afc033074934d4fd04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -29 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping.html View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl.html View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png View Binary file 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 6 chunks +40 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainter.cpp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rhogan
Created Reland of Don't paint underline or selections over ellipsis in mixed-flow contexts
3 years, 11 months ago (2017-01-05 22:47:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611233002/1
3 years, 11 months ago (2017-01-05 22:48:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/495d8354acfb5558725043afc033074934d4fd04
3 years, 11 months ago (2017-01-05 22:50:13 UTC) #6
eae
LGTM post-facto
3 years, 11 months ago (2017-01-05 22:57:48 UTC) #7
loyso (OOO)
May it be a culprit for ast/text/ellipsis-stroked.html failures? https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/41368
3 years, 11 months ago (2017-01-06 04:35:33 UTC) #8
loyso (OOO)
3 years, 11 months ago (2017-01-06 04:37:49 UTC) #9
Message was sent while issue was closed.
https://bugs.chromium.org/p/chromium/issues/detail?id=678388

Powered by Google App Engine
This is Rietveld 408576698