Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2611193002: s390: fix smi compare in DoBoundsCheck (Closed)

Created:
3 years, 11 months ago by john.yan
Modified:
3 years, 11 months ago
Reviewers:
JoranSiu, JaideepBajwa
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: fix smi compare in DoBoundsCheck CmpLogicalP only compares lower 32-bit, but smi is in upper 32-bit R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2611193002 Cr-Commit-Position: refs/heads/master@{#42100} Committed: https://chromium.googlesource.com/v8/v8/+/95040300ee25dc6b184f4951b518449a0af79df0

Patch Set 1 : fix1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/crankshaft/s390/lithium-codegen-s390.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
john.yan
ptal
3 years, 11 months ago (2017-01-05 20:00:56 UTC) #1
JaideepBajwa
lgtm
3 years, 11 months ago (2017-01-05 20:23:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611193002/20001
3 years, 11 months ago (2017-01-05 20:34:14 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 21:00:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/95040300ee25dc6b184f4951b518449a0af...

Powered by Google App Engine
This is Rietveld 408576698