Service Manager: Miscellaneous catalog cleanup

Service Manager: Miscellaneous catalog cleanup

Simplifies lifetime management of catalog Entry objects, introducing
a hierarchical EntryCache with global lookup.

Also takes care of some other miscellaneous cleanup encountered along
the way.

BUG=672614
Review-Url: https://codereview.chromium.org/2611183006
Cr-Commit-Position: refs/heads/master@{#442171}
Committed: https://chromium.googlesource.com/chromium/src/+/07e10fd70e44126d20a19b639fb18deee52cd906

[Ken Rockot(use gerrit already), 2017-01-07 00:17:38]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-07 00:18:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-01-07 00:19:36]

rockot@chromium.org changed reviewers:
+ ben@chromium.org

[Ken Rockot(use gerrit already), 2017-01-07 00:19:36]

These are some changes that were part of my attempt to flatten the catalog.
Ultimately I decided against doing that in favor of something else (future
patch), but I liked some bits of the CL so I thought I'd try to land them.

[commit-bot: I haz the power, 2017-01-07 01:26:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 01:26:29]

Dry run: This issue passed the CQ dry run.

[Ben Goodger (Google), 2017-01-07 19:29:55]

lgtm

https://codereview.chromium.org/2611183006/diff/1/services/service_manager/se...
File services/service_manager/service_manager.cc (left):

https://codereview.chromium.org/2611183006/diff/1/services/service_manager/se...
services/service_manager/service_manager.cc:836: instance_name =
result->qualifier;
so this means it's not possible to specify an instance name in manifest now?

i think that's ok since we don't use it for anything yet?

[Ken Rockot(use gerrit already), 2017-01-07 19:34:40]

On 2017/01/07 at 19:29:55, ben wrote:
> lgtm
> 
>
https://codereview.chromium.org/2611183006/diff/1/services/service_manager/se...
> File services/service_manager/service_manager.cc (left):
> 
>
https://codereview.chromium.org/2611183006/diff/1/services/service_manager/se...
> services/service_manager/service_manager.cc:836: instance_name =
result->qualifier;
> so this means it's not possible to specify an instance name in manifest now?
> 
> i think that's ok since we don't use it for anything yet?

Correct - in fact we apparently stopped reading this property from manifests a
while ago, so it's just dead code.

[Ken Rockot(use gerrit already), 2017-01-07 19:34:44]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2017-01-07 19:34:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 19:39:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483817684872880, "parent_rev":
"0f762fedb8512772504cd5548b93f2523ec1e3a2", "commit_rev":
"07e10fd70e44126d20a19b639fb18deee52cd906"}

[commit-bot: I haz the power, 2017-01-07 19:39:42]

Description was changed from

==========
Service Manager: Miscellaneous catalog cleanup

Simplifies lifetime management of catalog Entry objects, introducing
a hierarchical EntryCache with global lookup.

Also takes care of some other miscellaneous cleanup encountered along
the way.

BUG=672614
==========

to

==========
Service Manager: Miscellaneous catalog cleanup

Simplifies lifetime management of catalog Entry objects, introducing
a hierarchical EntryCache with global lookup.

Also takes care of some other miscellaneous cleanup encountered along
the way.

BUG=672614

Review-Url: https://codereview.chromium.org/2611183006
Cr-Commit-Position: refs/heads/master@{#442171}
Committed:
https://chromium.googlesource.com/chromium/src/+/07e10fd70e44126d20a19b639fb1...
==========

[commit-bot: I haz the power, 2017-01-07 19:39:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/07e10fd70e44126d20a19b639fb1...

[Wez, 2017-02-07 02:27:41]

wez@chromium.org changed reviewers:
+ tsepez@chromium.org, wez@chromium.org

[Wez, 2017-02-07 02:27:41]

Hallo tsepez@chromium.org!
Due to a depot_tools patch which mistakenly removed the OWNERS check for
non-source files (see crbug.com/684270), the following files landed in this CL
and need a retrospective review from you:
	content/content_resources.grd
	services/catalog/BUILD.gn
	services/service_manager/public/interfaces/resolver.mojom
Thanks,
Wez

[Wez, 2017-02-07 02:52:55]

Correction; only the .mojom needs retrospective review.