Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 2611183005: Add "Useful Logs and Debugging Info" section to perf sheriff doc. (Closed)

Created:
3 years, 11 months ago by mikecase (-- gone --)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add "Useful Logs and Debugging Info" section to perf sheriff doc. We have lots of places with useful debugging info but it can be hard to find and to know what is useful to look at. I think it would be useful to add a section to the perf sheriff doc dedicated to describing the logging info that we have set up. Review-Url: https://codereview.chromium.org/2611183005 Cr-Commit-Position: refs/heads/master@{#442294} Committed: https://chromium.googlesource.com/chromium/src/+/abbb2541620aa14479081acce93c94c52523b6d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -8 lines) Patch
M tools/perf/docs/perf_bot_sheriffing.md View 2 chunks +45 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mikecase (wrong mikecase)
What do you guys think of a section like this for the perf sheriff doc.
3 years, 11 months ago (2017-01-06 23:45:25 UTC) #2
eyaich1
lgtm
3 years, 11 months ago (2017-01-09 14:33:05 UTC) #3
sullivan
lgtm This is awesome! Thanks so much!
3 years, 11 months ago (2017-01-09 14:35:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611183005/1
3 years, 11 months ago (2017-01-09 17:04:20 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 18:17:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/abbb2541620aa14479081acce93c...

Powered by Google App Engine
This is Rietveld 408576698