Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2611173003: [chromecast] Do not link with -latomic (Closed)

Created:
3 years, 11 months ago by wzhong
Modified:
3 years, 11 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromecast] Do not link with -latomic "-latomic" flag is not necessary. Besides, libatomic.so is unavailable in the next toolchain update. BUG= internal b/33944287 TEST= builds. Review-Url: https://codereview.chromium.org/2611173003 Cr-Commit-Position: refs/heads/master@{#442080} Committed: https://chromium.googlesource.com/chromium/src/+/444e0bbea061042b4133f3bfea0c8d0a6db73aff

Patch Set 1 #

Patch Set 2 : Fixed gn format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
wzhong
3 years, 11 months ago (2017-01-06 20:17:14 UTC) #4
bcf
lgtm
3 years, 11 months ago (2017-01-06 20:19:39 UTC) #5
slan
lgtm. I don't quite understand the original need for this library though.
3 years, 11 months ago (2017-01-06 20:21:45 UTC) #6
wzhong
On 2017/01/06 20:21:45, slan wrote: > lgtm. I don't quite understand the original need for ...
3 years, 11 months ago (2017-01-06 20:40:05 UTC) #7
dcheng
lgtm
3 years, 11 months ago (2017-01-06 21:29:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611173003/20001
3 years, 11 months ago (2017-01-06 22:25:21 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 22:44:08 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/444e0bbea061042b4133f3bfea0c...

Powered by Google App Engine
This is Rietveld 408576698