Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2611163003: Remove ContextClient from DOMWindowCrypto (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextClient from DOMWindowCrypto It's not needed. BUG=610176 Review-Url: https://codereview.chromium.org/2611163003 Cr-Commit-Position: refs/heads/master@{#441900} Committed: https://chromium.googlesource.com/chromium/src/+/4f38a5bc4bdc0aa1163d1b9375867f07d4a0cdcf

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M third_party/WebKit/Source/modules/crypto/DOMWindowCrypto.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/crypto/DOMWindowCrypto.cpp View 3 chunks +2 lines, -3 lines 1 comment Download

Messages

Total messages: 12 (8 generated)
haraken
PTAL https://codereview.chromium.org/2611163003/diff/1/third_party/WebKit/Source/modules/crypto/DOMWindowCrypto.cpp File third_party/WebKit/Source/modules/crypto/DOMWindowCrypto.cpp (left): https://codereview.chromium.org/2611163003/diff/1/third_party/WebKit/Source/modules/crypto/DOMWindowCrypto.cpp#oldcode60 third_party/WebKit/Source/modules/crypto/DOMWindowCrypto.cpp:60: if (!m_crypto && frame()) This check won't make ...
3 years, 11 months ago (2017-01-06 01:40:38 UTC) #3
sof
lgtm
3 years, 11 months ago (2017-01-06 07:41:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611163003/1
3 years, 11 months ago (2017-01-06 07:55:47 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 07:59:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f38a5bc4bdc0aa1163d1b937586...

Powered by Google App Engine
This is Rietveld 408576698