Convert AudioContext Audit tests to testharness

Convert AudioContext Audit tests to testharness

Conversion done using this script:

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

Since the original tests didn't actually use any of the old
Audit.Should() functions, we took this opportunity to convert it to
the new Audit.should() because we had to convert the old js-test
functions anyway.

BUG=678701
TEST=AudioContext/audiocontext-close.html,
AudioContext/audiocontext-suspend-resume.html

Review-Url: https://codereview.chromium.org/2611133003
Cr-Commit-Position: refs/heads/master@{#445529}
Committed: https://chromium.googlesource.com/chromium/src/+/3aee9f268a3a471fa539d704e622aee1ce68f0ce

[Raymond Toy, 2017-01-05 22:43:57]

Patchset #2 (id:20001) has been deleted

[Raymond Toy, 2017-01-17 19:14:25]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-01-17 19:14:26]

PTAL

[hongchan, 2017-01-20 23:08:41]

https://codereview.chromium.org/2611133003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html
(right):

https://codereview.chromium.org/2611133003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html:31:
.notThrow();;
Two semicolons.

https://codereview.chromium.org/2611133003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html:36:
should(function () {
Let's use () => {} notation.

https://codereview.chromium.org/2611133003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html:124:
.throw(
No line break needed.

https://codereview.chromium.org/2611133003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html:153:

An extra line added here.

[Raymond Toy, 2017-01-23 19:24:59]

https://codereview.chromium.org/2611133003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html
(right):

https://codereview.chromium.org/2611133003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html:31:
.notThrow();;
On 2017/01/20 23:08:41, hongchan wrote:
> Two semicolons.

Done.

https://codereview.chromium.org/2611133003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html:36:
should(function () {
On 2017/01/20 23:08:41, hongchan wrote:
> Let's use () => {} notation.

Done.

https://codereview.chromium.org/2611133003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html:124:
.throw(
On 2017/01/20 23:08:41, hongchan wrote:
> No line break needed.

Done.

https://codereview.chromium.org/2611133003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html:153:

On 2017/01/20 23:08:41, hongchan wrote:
> An extra line added here.

Done.

[hongchan, 2017-01-23 19:42:37]

lgtm with nits

https://codereview.chromium.org/2611133003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html
(right):

https://codereview.chromium.org/2611133003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html:44:
.notThrow("");
Remove |""|.

https://codereview.chromium.org/2611133003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html:54:
.then(task.done.bind(this));
This is slightly confusing. Can we do something like this?

let promise = context.close().then(....);

should(promise, 'context.close()')
    .beResolved()
    .then(() => { task.done(); });

[Raymond Toy, 2017-01-23 20:32:07]

https://codereview.chromium.org/2611133003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html
(right):

https://codereview.chromium.org/2611133003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html:44:
.notThrow("");
On 2017/01/23 19:42:37, hongchan wrote:
> Remove |""|.

Done.

https://codereview.chromium.org/2611133003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html:54:
.then(task.done.bind(this));
On 2017/01/23 19:42:37, hongchan wrote:
> This is slightly confusing. Can we do something like this?
> 
> let promise = context.close().then(....);
> 
> should(promise, 'context.close()')
>     .beResolved()
>     .then(() => { task.done(); });

Done.

[Raymond Toy, 2017-01-23 20:32:22]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-01-23 20:32:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2611133003/#ps60001
(title: "Address nits")

[commit-bot: I haz the power, 2017-01-23 20:32:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 23:00:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485203542846870,
"parent_rev": "5d8596504544ee64049242d88b15fc3a79295519", "commit_rev":
"3aee9f268a3a471fa539d704e622aee1ce68f0ce"}

[commit-bot: I haz the power, 2017-01-23 23:01:29]

Description was changed from

==========
Convert AudioContext Audit tests to testharness

Conversion done using this script:

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

Since the original tests didn't actually use any of the old
Audit.Should() functions, we took this opportunity to convert it to
the new Audit.should() because we had to convert the old js-test
functions anyway.

BUG=678701
TEST=AudioContext/audiocontext-close.html,
AudioContext/audiocontext-suspend-resume.html
==========

to

==========
Convert AudioContext Audit tests to testharness

Conversion done using this script:

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

Since the original tests didn't actually use any of the old
Audit.Should() functions, we took this opportunity to convert it to
the new Audit.should() because we had to convert the old js-test
functions anyway.

BUG=678701
TEST=AudioContext/audiocontext-close.html,
AudioContext/audiocontext-suspend-resume.html

Review-Url: https://codereview.chromium.org/2611133003
Cr-Commit-Position: refs/heads/master@{#445529}
Committed:
https://chromium.googlesource.com/chromium/src/+/3aee9f268a3a471fa539d704e622...
==========

[commit-bot: I haz the power, 2017-01-23 23:01:30]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3aee9f268a3a471fa539d704e622...