Remove ContextClient from NavigatorBeacon

Remove ContextClient from NavigatorBeacon

Now that Navigator's Supplements can retrieve the Navigator object with host(),
those Supplements don't need to observe ContextClient.

BUG=610176
Review-Url: https://codereview.chromium.org/2611133002
Cr-Commit-Position: refs/heads/master@{#442873}
Committed: https://chromium.googlesource.com/chromium/src/+/cdf612491968c39e7d86847308e8a9225f19e7af

[haraken, 2017-01-05 11:45:09]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2017-01-05 11:45:10]

PTAL

[haraken, 2017-01-05 11:48:37]

https://codereview.chromium.org/2611133002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp (left):

https://codereview.chromium.org/2611133002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp:73: if (!frame() ||
!frame()->client())

frame()->client() is not needed because host()->frame() returns null when the
frame is detached.

[sof, 2017-01-05 12:05:40]

https://codereview.chromium.org/2611133002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp (left):

https://codereview.chromium.org/2611133002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp:73: if (!frame() ||
!frame()->client())
On 2017/01/05 11:48:37, haraken wrote:
> 
> frame()->client() is not needed because host()->frame() returns null when the
> frame is detached.

It might be worth clarifying somewhere that |host()| will never ever be null.

https://codereview.chromium.org/2611133002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp (right):

https://codereview.chromium.org/2611133002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp:24: :
m_transmittedBytes(0) {}
Don't you need to invoke the Supplement<Navigator>(..) constructor?

[haraken, 2017-01-05 12:16:50]

On 2017/01/05 12:05:40, sof wrote:
>
https://codereview.chromium.org/2611133002/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp (left):
> 
>
https://codereview.chromium.org/2611133002/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp:73: if (!frame()
||
> !frame()->client())
> On 2017/01/05 11:48:37, haraken wrote:
> > 
> > frame()->client() is not needed because host()->frame() returns null when
the
> > frame is detached.
> 
> It might be worth clarifying somewhere that |host()| will never ever be null.
> 
>
https://codereview.chromium.org/2611133002/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp (right):
> 
>
https://codereview.chromium.org/2611133002/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp:24: :
> m_transmittedBytes(0) {}
> Don't you need to invoke the Supplement<Navigator>(..) constructor?

Good point. Fixed.

[sof, 2017-01-05 12:20:08]

lgtm

[haraken, 2017-01-05 12:30:09]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2017-01-05 12:30:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 14:30:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 14:30:28]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[haraken, 2017-01-11 08:30:45]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2017-01-11 08:31:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 08:33:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 08:33:52]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[haraken, 2017-01-11 09:16:51]

The CQ bit was checked by haraken@chromium.org

[haraken, 2017-01-11 09:16:51]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2611133002/#ps80001
(title: "temp")

[commit-bot: I haz the power, 2017-01-11 09:17:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 10:55:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 10:55:16]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[haraken, 2017-01-11 11:08:52]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2017-01-11 11:09:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 11:54:26]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484132932467040,
"parent_rev": "23c0a1653b13e37b6ab09f155b88e3578ad16520", "commit_rev":
"cdf612491968c39e7d86847308e8a9225f19e7af"}

[commit-bot: I haz the power, 2017-01-11 11:54:58]

Description was changed from

==========
Remove ContextClient from NavigatorBeacon

Now that Navigator's Supplements can retrieve the Navigator object with host(),
those Supplements don't need to observe ContextClient.

BUG=610176
==========

to

==========
Remove ContextClient from NavigatorBeacon

Now that Navigator's Supplements can retrieve the Navigator object with host(),
those Supplements don't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2611133002
Cr-Commit-Position: refs/heads/master@{#442873}
Committed:
https://chromium.googlesource.com/chromium/src/+/cdf612491968c39e7d86847308e8...
==========

[commit-bot: I haz the power, 2017-01-11 11:54:59]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/cdf612491968c39e7d86847308e8...