[Sync] ModelTypeWorker should delete tracker for entity deleted on the server

[Sync] ModelTypeWorker should delete tracker for entity deleted on the server

The issue is that when entity is deleted, worker retains entity tracker object.
Later when entity is recreated information from old tracker object is used.

I'm changing worker to delete tracker object when it receives commit response
about deleted entity.

BUG=677792
R=maxbogue@chromium.org

Review-Url: https://codereview.chromium.org/2611123005
Cr-Commit-Position: refs/heads/master@{#442350}
Committed: https://chromium.googlesource.com/chromium/src/+/a110d353ecca5d521ce7ec513e0493c98f0b37ed

[pavely, 2017-01-06 18:50:36]

The CQ bit was checked by pavely@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 18:51:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 20:33:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 20:33:40]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2017-01-07 02:03:37]

I thought we decided we had to keep the entity around until the processor got
the commit response, no? Let's chat Monday.

[maxbogue, 2017-01-09 19:44:48]

I was reminded offline that this is a special case that we can handle because
the delete is coming from our local client. lgtm w/ a little nit!

https://codereview.chromium.org/2611123005/diff/20001/components/sync/engine_...
File components/sync/engine_impl/worker_entity_tracker.h (right):

https://codereview.chromium.org/2611123005/diff/20001/components/sync/engine_...
components/sync/engine_impl/worker_entity_tracker.h:44: bool IsTombstone()
const;
nit: I'd prefer PendingCommitIsTombstone or PendingCommitIsDeletion. That makes
it clearer that the method is only valid to call if HasPendingCommit is true.

[pavely, 2017-01-09 20:14:39]

The CQ bit was checked by pavely@chromium.org

[pavely, 2017-01-09 20:14:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxbogue@chromium.org
Link to the patchset: https://codereview.chromium.org/2611123005/#ps40001
(title: "Address comment")

[commit-bot: I haz the power, 2017-01-09 20:15:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 21:24:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483992879348480,
"parent_rev": "2bc003a0eadbd4062770b206fa76311f55d0c54e", "commit_rev":
"a110d353ecca5d521ce7ec513e0493c98f0b37ed"}

[commit-bot: I haz the power, 2017-01-09 21:25:01]

Description was changed from

==========
[Sync] ModelTypeWorker should delete tracker for entity deleted on the server

The issue is that when entity is deleted, worker retains entity tracker object.
Later when entity is recreated information from old tracker object is used.

I'm changing worker to delete tracker object when it receives commit response
about deleted entity.

BUG=677792
R=maxbogue@chromium.org
==========

to

==========
[Sync] ModelTypeWorker should delete tracker for entity deleted on the server

The issue is that when entity is deleted, worker retains entity tracker object.
Later when entity is recreated information from old tracker object is used.

I'm changing worker to delete tracker object when it receives commit response
about deleted entity.

BUG=677792
R=maxbogue@chromium.org

Review-Url: https://codereview.chromium.org/2611123005
Cr-Commit-Position: refs/heads/master@{#442350}
Committed:
https://chromium.googlesource.com/chromium/src/+/a110d353ecca5d521ce7ec513e04...
==========

[commit-bot: I haz the power, 2017-01-09 21:25:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a110d353ecca5d521ce7ec513e04...