Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2611083002: [promises] Add AllocatePromiseResolveThenableJobInfo to TF (Closed)

Created:
3 years, 11 months ago by gsathya
Modified:
3 years, 11 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] Add AllocatePromiseResolveThenableJobInfo to TF Also moves most of the runtime function into TF. There are lots of runtime calls but they happen only for the debug case so it's fine. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2611083002 Cr-Commit-Position: refs/heads/master@{#42109} Committed: https://chromium.googlesource.com/v8/v8/+/677bd40ea6f4ab1babe24168443115451fbec3a2

Patch Set 1 #

Patch Set 2 : remove dead code #

Patch Set 3 : Remove more dead code #

Patch Set 4 : move more stuff to tf #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -113 lines) Patch
M src/builtins/builtins-promise.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/builtins/builtins-promise.cc View 1 2 3 3 chunks +49 lines, -4 lines 0 comments Download
M src/factory.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/factory.cc View 1 1 chunk +0 lines, -17 lines 0 comments Download
M src/promise-utils.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M src/promise-utils.cc View 1 2 1 chunk +0 lines, -37 lines 0 comments Download
M src/runtime/runtime.h View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-promise.cc View 1 2 3 4 2 chunks +2 lines, -41 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (24 generated)
gsathya
3 years, 11 months ago (2017-01-05 01:02:26 UTC) #4
Igor Sheludko
lgtm
3 years, 11 months ago (2017-01-06 10:40:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611083002/60001
3 years, 11 months ago (2017-01-06 14:33:33 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/14639) v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 11 months ago (2017-01-06 14:34:43 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611083002/80001
3 years, 11 months ago (2017-01-06 15:27:28 UTC) #27
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 15:29:18 UTC) #30
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/677bd40ea6f4ab1babe24168443115451fb...

Powered by Google App Engine
This is Rietveld 408576698