Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2611063003: Fix issue with audio input streams where an error would not be reported (Closed)

Created:
3 years, 11 months ago by tommi (sloooow) - chröme
Modified:
3 years, 11 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix issue with audio input streams where an error would not be reported if an initialization error occurs while creating an audio stream. BUG=678697 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2611063003 Cr-Commit-Position: refs/heads/master@{#441758} Committed: https://chromium.googlesource.com/chromium/src/+/c57d9c242d1be6076c12838c4fc91a081b887c01

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -11 lines) Patch
M media/audio/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/audio_input_device.cc View 1 chunk +18 lines, -11 lines 0 comments Download
A media/audio/audio_input_device_unittest.cc View 1 chunk +91 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
tommi (sloooow) - chröme
3 years, 11 months ago (2017-01-05 19:12:29 UTC) #3
tommi (sloooow) - chröme
On 2017/01/05 19:12:29, tommi (chrömium) wrote: Hey Sergey - I picked you as a reviewer ...
3 years, 11 months ago (2017-01-05 19:13:28 UTC) #4
Sergey Ulanov
lgtm
3 years, 11 months ago (2017-01-05 20:39:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611063003/1
3 years, 11 months ago (2017-01-05 21:24:21 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 21:29:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c57d9c242d1be6076c12838c4fc9...

Powered by Google App Engine
This is Rietveld 408576698