Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2611053004: Use setNeedsActiveStyleUpdate instead of markTreeScopeDirty. (Closed)

Created:
3 years, 11 months ago by rune
Modified:
3 years, 11 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use setNeedsActiveStyleUpdate instead of markTreeScopeDirty. setNeedsActiveStyleUpdate checks if the document is active before calling markTreeScopeDirty. This avoids marking shadow root tree scopes dirty for non-active documents which caused a DCHECK fail in markTreeScopeDirty. R=esprehn@chromium.org BUG=676441 Review-Url: https://codereview.chromium.org/2611053004 Cr-Commit-Position: refs/heads/master@{#442028} Committed: https://chromium.googlesource.com/chromium/src/+/9ea74b3f541f6850a48f6a2b4d08f3d4de95dcf4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/shadow/move-shadow-host-to-child-iframe-crash.html View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
rune
ptal
3 years, 11 months ago (2017-01-06 17:25:19 UTC) #9
esprehn
lgtm
3 years, 11 months ago (2017-01-06 20:22:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611053004/1
3 years, 11 months ago (2017-01-06 20:23:22 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 20:29:33 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9ea74b3f541f6850a48f6a2b4d08...

Powered by Google App Engine
This is Rietveld 408576698