[layoutng] Make RunOldLayout respect IsFixedSize

[layoutng] Make RunOldLayout respect IsFixedSize

If IsFixedSize is true for a dimension, sets the override size
accordingly, matching the code in ng_length_utils.

Also adds a comment to ng_constraint_space.h for how this works
(could've sworn that we already had such a comment)

R=eae@chromium.org,atotic@chromium.org
BUG=635619
Review-Url: https://codereview.chromium.org/2611033002
Cr-Commit-Position: refs/heads/master@{#441713}
Committed: https://chromium.googlesource.com/chromium/src/+/a918c03eaaf3670312aae46b812ffa16012ad338

[cbiesinger, 2017-01-04 22:37:58]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 22:38:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[atotic, 2017-01-04 23:54:05]

On 2017/01/04 at 22:37:57, cbiesinger wrote:
> 

Did not work for abspos. Abspos constraint_space's:
AvailableSize() is the size of the new block
PercentageResolutionSize() is the size of the containing block

In the patch, PercentageResolutionSize is not getting passed to old layout.

[cbiesinger1, 2017-01-05 00:10:44]

On 2017/01/04 at 23:54:05, atotic wrote:
> On 2017/01/04 at 22:37:57, cbiesinger wrote:
> > 
> 
> Did not work for abspos. Abspos constraint_space's:
> AvailableSize() is the size of the new block
> PercentageResolutionSize() is the size of the containing block
> 
> In the patch, PercentageResolutionSize is not getting passed to old layout.

You're right, the percentage size should be the one passed to override
containing block size. I will fix that.

But, that shouldn't matter if setting a fixed size, isn't that what you do?

[atotic, 2017-01-05 00:25:39]

On 2017/01/05 at 00:10:44, cbiesinger wrote:
> On 2017/01/04 at 23:54:05, atotic wrote:
> > On 2017/01/04 at 22:37:57, cbiesinger wrote:
> > > 
> > 
> > Did not work for abspos. Abspos constraint_space's:
> > AvailableSize() is the size of the new block
> > PercentageResolutionSize() is the size of the containing block
> > 
> > In the patch, PercentageResolutionSize is not getting passed to old layout.
> 
> You're right, the percentage size should be the one passed to override
containing block size. I will fix that.
> 
> But, that shouldn't matter if setting a fixed size, isn't that what you do?

I do set the fixed size. But percentage size and available size can be
different.

[cbiesinger, 2017-01-05 01:18:17]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 01:18:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2017-01-05 01:19:32]

On 2017/01/05 00:25:39, atotic wrote:
> On 2017/01/05 at 00:10:44, cbiesinger wrote:
> > On 2017/01/04 at 23:54:05, atotic wrote:
> > > On 2017/01/04 at 22:37:57, cbiesinger wrote:
> > > > 
> > > 
> > > Did not work for abspos. Abspos constraint_space's:
> > > AvailableSize() is the size of the new block
> > > PercentageResolutionSize() is the size of the containing block
> > > 
> > > In the patch, PercentageResolutionSize is not getting passed to old
layout.
> > 
> > You're right, the percentage size should be the one passed to override
> containing block size. I will fix that.
> > 
> > But, that shouldn't matter if setting a fixed size, isn't that what you do?
> 
> I do set the fixed size. But percentage size and available size can be
> different.

Uploaded a new version that handles percentage sizing correctly, though I'm not
sure I understand your issue correctly.

[commit-bot: I haz the power, 2017-01-05 02:44:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 02:44:01]

Dry run: This issue passed the CQ dry run.

[atotic, 2017-01-05 17:02:54]

On 2017/01/05 at 01:19:32, cbiesinger wrote:
> On 2017/01/05 00:25:39, atotic wrote:
> > On 2017/01/05 at 00:10:44, cbiesinger wrote:
> > > On 2017/01/04 at 23:54:05, atotic wrote:
> > > > On 2017/01/04 at 22:37:57, cbiesinger wrote:
> > > > > 
> > > > 
> > > > Did not work for abspos. Abspos constraint_space's:
> > > > AvailableSize() is the size of the new block
> > > > PercentageResolutionSize() is the size of the containing block
> > > > 
> > > > In the patch, PercentageResolutionSize is not getting passed to old
layout.
> > > 
> > > You're right, the percentage size should be the one passed to override
> > containing block size. I will fix that.
> > > 
> > > But, that shouldn't matter if setting a fixed size, isn't that what you
do?
> > 
> > I do set the fixed size. But percentage size and available size can be
> > different.
> 
> Uploaded a new version that handles percentage sizing correctly, though I'm
not sure I understand your issue correctly.

Looks correct, but my abspos example still renders incorrectly.

[eae, 2017-01-05 18:15:28]

LGTM but please make sure Aleks is happy before you land.

[atotic, 2017-01-05 18:29:15]

On 2017/01/05 at 18:15:28, eae wrote:
> LGTM but please make sure Aleks is happy before you land.

lgtm. Bug is somewhere else.

[cbiesinger, 2017-01-05 18:37:09]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2017-01-05 18:37:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 18:47:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483641429382340,
"parent_rev": "8f983db3a8ae9058070528ed2ec2034bedc6976e", "commit_rev":
"a918c03eaaf3670312aae46b812ffa16012ad338"}

[commit-bot: I haz the power, 2017-01-05 18:48:20]

Description was changed from

==========
[layoutng] Make RunOldLayout respect IsFixedSize

If IsFixedSize is true for a dimension, sets the override size
accordingly, matching the code in ng_length_utils.

Also adds a comment to ng_constraint_space.h for how this works
(could've sworn that we already had such a comment)

R=eae@chromium.org,atotic@chromium.org
BUG=635619
==========

to

==========
[layoutng] Make RunOldLayout respect IsFixedSize

If IsFixedSize is true for a dimension, sets the override size
accordingly, matching the code in ng_length_utils.

Also adds a comment to ng_constraint_space.h for how this works
(could've sworn that we already had such a comment)

R=eae@chromium.org,atotic@chromium.org
BUG=635619

Review-Url: https://codereview.chromium.org/2611033002
Cr-Commit-Position: refs/heads/master@{#441713}
Committed:
https://chromium.googlesource.com/chromium/src/+/a918c03eaaf3670312aae46b812f...
==========

[commit-bot: I haz the power, 2017-01-05 18:48:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a918c03eaaf3670312aae46b812f...