[Android] Fix subthread native test execution race condition.

[Android] Fix subthread native test execution race condition.

On L and M, the system posts a task to the main thread after start() returns
that prints a few lines to stdout. Our existing subthread execution model
allowed the tests to run at the same time as this task, resulting in the
task's output interfering with the tests' output.

This change tweaks our subthread test launching logic to post a task to the
main thread that posts another task to the main thread that launches the test
subthread. This should ensure that the system task gets executed before we
start running tests.

BUG=678146
Committed: https://crrev.com/ff8298584409040003a088792394d4ea3101f8d4
Cr-Commit-Position: refs/heads/master@{#441458}

[jbudorick, 2017-01-04 19:24:11]

jbudorick@chromium.org changed reviewers:
+ jcivelli@chromium.org

[Jay Civelli, 2017-01-04 19:36:05]

lgtm

Nit: there is a typo in the CL's message: s/intefering/interfering

https://codereview.chromium.org/2610983002/diff/1/testing/android/native_test...
File
testing/android/native_test/java/src/org/chromium/native_test/NativeTest.java
(right):

https://codereview.chromium.org/2610983002/diff/1/testing/android/native_test...
testing/android/native_test/java/src/org/chromium/native_test/NativeTest.java:131:
final Runnable r = new Runnable() {
Nit: maybe name it a clearer name? runTestsRunnable?

[jbudorick, 2017-01-04 19:59:01]

Description was changed from

==========
[Android] Fix subthread native test execution race condition.

On L and M, the system posts a task to the main thread after start() returns
that prints a few lines to stdout. Our existing subthread execution model
allowed the tests to run at the same time as this task, resulting in the
task's output intefering with the tests' output.

This change tweaks our subthread test launching logic to post a task to the
main thread that posts another task to the main thread that launches the test
subthread. This should ensure that the system task gets executed before we
start running tests.

BUG=678146
==========

to

==========
[Android] Fix subthread native test execution race condition.

On L and M, the system posts a task to the main thread after start() returns
that prints a few lines to stdout. Our existing subthread execution model
allowed the tests to run at the same time as this task, resulting in the
task's output interfering with the tests' output.

This change tweaks our subthread test launching logic to post a task to the
main thread that posts another task to the main thread that launches the test
subthread. This should ensure that the system task gets executed before we
start running tests.

BUG=678146
==========

[jbudorick, 2017-01-04 19:59:22]

Fixed the description typo.

https://codereview.chromium.org/2610983002/diff/1/testing/android/native_test...
File
testing/android/native_test/java/src/org/chromium/native_test/NativeTest.java
(right):

https://codereview.chromium.org/2610983002/diff/1/testing/android/native_test...
testing/android/native_test/java/src/org/chromium/native_test/NativeTest.java:131:
final Runnable r = new Runnable() {
On 2017/01/04 19:36:05, Jay Civelli wrote:
> Nit: maybe name it a clearer name? runTestsRunnable?

Renamed to runTestsTask + renamed the other two Runnables in here to end in
Task.

[jbudorick, 2017-01-04 20:11:01]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2017-01-04 20:11:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
jcivelli@chromium.org
Link to the patchset: https://codereview.chromium.org/2610983002/#ps20001
(title: "jcivelli comments")

[commit-bot: I haz the power, 2017-01-04 20:11:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 20:53:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483560661108690,
"parent_rev": "6811925daada62e232c096381e55e60dab9ce38a", "commit_rev":
"42a38e94acb3df1528f6df035a78d3cde644ab93"}

[commit-bot: I haz the power, 2017-01-04 20:53:41]

Description was changed from

==========
[Android] Fix subthread native test execution race condition.

On L and M, the system posts a task to the main thread after start() returns
that prints a few lines to stdout. Our existing subthread execution model
allowed the tests to run at the same time as this task, resulting in the
task's output interfering with the tests' output.

This change tweaks our subthread test launching logic to post a task to the
main thread that posts another task to the main thread that launches the test
subthread. This should ensure that the system task gets executed before we
start running tests.

BUG=678146
==========

to

==========
[Android] Fix subthread native test execution race condition.

On L and M, the system posts a task to the main thread after start() returns
that prints a few lines to stdout. Our existing subthread execution model
allowed the tests to run at the same time as this task, resulting in the
task's output interfering with the tests' output.

This change tweaks our subthread test launching logic to post a task to the
main thread that posts another task to the main thread that launches the test
subthread. This should ensure that the system task gets executed before we
start running tests.

BUG=678146

Review-Url: https://codereview.chromium.org/2610983002
==========

[commit-bot: I haz the power, 2017-01-04 20:53:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-04 20:57:39]

Description was changed from

==========
[Android] Fix subthread native test execution race condition.

On L and M, the system posts a task to the main thread after start() returns
that prints a few lines to stdout. Our existing subthread execution model
allowed the tests to run at the same time as this task, resulting in the
task's output interfering with the tests' output.

This change tweaks our subthread test launching logic to post a task to the
main thread that posts another task to the main thread that launches the test
subthread. This should ensure that the system task gets executed before we
start running tests.

BUG=678146

Review-Url: https://codereview.chromium.org/2610983002
==========

to

==========
[Android] Fix subthread native test execution race condition.

On L and M, the system posts a task to the main thread after start() returns
that prints a few lines to stdout. Our existing subthread execution model
allowed the tests to run at the same time as this task, resulting in the
task's output interfering with the tests' output.

This change tweaks our subthread test launching logic to post a task to the
main thread that posts another task to the main thread that launches the test
subthread. This should ensure that the system task gets executed before we
start running tests.

BUG=678146

Committed: https://crrev.com/ff8298584409040003a088792394d4ea3101f8d4
Cr-Commit-Position: refs/heads/master@{#441458}
==========

[commit-bot: I haz the power, 2017-01-04 20:57:39]

Patchset 2 (id:??) landed as
https://crrev.com/ff8298584409040003a088792394d4ea3101f8d4
Cr-Commit-Position: refs/heads/master@{#441458}