Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2610973002: Fix a pair of bugs in UNIX->VMS path conversion. (Closed)

Created:
3 years, 11 months ago by mmenke
Modified:
3 years, 11 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, Paweł Hajdan Jr.
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a pair of bugs in UNIX->VMS path conversion. In particular: * Fix conversion of UNIX file name "/////file" and "////" as a UNIX path. Both of these were broken, due to the same bug. * Remove a DCHECK that would trigger on "//" as a file name. It's a valid UNIX path, if not a file name, and can still be passed through the file name conversion code. Since there's no code to prevent that from happening, and the conversion code handles "/", the DCHECK made no sense. BUG=675111 Committed: https://crrev.com/dbb6723c81a3d595aa3cc593acac9bb93b328398 Cr-Commit-Position: refs/heads/master@{#441423}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -22 lines) Patch
M net/ftp/ftp_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_util_unittest.cc View 2 chunks +29 lines, -20 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
mmenke
¡Feliz Año Nuevo!
3 years, 11 months ago (2017-01-04 18:48:06 UTC) #5
eroman
lgtm
3 years, 11 months ago (2017-01-04 18:59:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610973002/1
3 years, 11 months ago (2017-01-04 19:01:30 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 19:09:39 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 19:12:25 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbb6723c81a3d595aa3cc593acac9bb93b328398
Cr-Commit-Position: refs/heads/master@{#441423}

Powered by Google App Engine
This is Rietveld 408576698