Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2610953002: Do not reload pengingItem to open Reading List offline page. (Closed)

Created:
3 years, 11 months ago by Olivier
Modified:
3 years, 11 months ago
Reviewers:
gambard
CC:
chromium-reviews, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not reload pengingItem to open Reading List offline page. Reload will delete Pending Item so altering it and reload will reload the lastCommittedItem. If there is a pending item, stop loading and trigger a new navigation. BUG=678293 Review-Url: https://codereview.chromium.org/2610953002 Cr-Commit-Position: refs/heads/master@{#441926} Committed: https://chromium.googlesource.com/chromium/src/+/9abd41a856d0d6ecf1f220181ffadac528290668

Patch Set 1 #

Patch Set 2 : fix unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -13 lines) Patch
M ios/chrome/browser/reading_list/reading_list_web_state_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/reading_list/reading_list_web_state_observer.mm View 5 chunks +18 lines, -9 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_web_state_observer_unittest.mm View 1 4 chunks +37 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Olivier
3 years, 11 months ago (2017-01-04 17:32:26 UTC) #2
gambard
lgtm
3 years, 11 months ago (2017-01-05 08:33:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610953002/1
3 years, 11 months ago (2017-01-06 09:43:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/132550)
3 years, 11 months ago (2017-01-06 10:07:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610953002/20001
3 years, 11 months ago (2017-01-06 12:19:30 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 12:30:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9abd41a856d0d6ecf1f220181ffa...

Powered by Google App Engine
This is Rietveld 408576698