Remove 'pkg' from the default list of test suites

tools/testing/dart/test_options.dart

Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index 66e0e0a6cee48e9922f837179173402760132717..8855aec7bd7ee8b26eb3a99d38fe5c46c1ce6a66 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -23,7 +23,6 @@ const List<String> defaultTestSelectors = const [
   'benchmark_smoke',
   'utils',
   'lib',
-  'pkg',

[kustermann, 2017/01/04 17:33:40]

We need to be careful here. I'm asking for pkg to be removed when we run vm (or
precompilation) tests. This is fine, because our buildbot explicitly passes
--exclude-suite=pkg.

BUT: There are other (non-vm) bots which actually do run 'pkg' (don't pass
--exclude-suite=pkg). For example:


python -u
/b/build/slave/dart2js-linux-d8-hostchecked-1-5-be/build/sdk/tools/test.py
'--mode=release' '--arch=ia32' '--compiler=dart2js' --dart2js-batch
'--runtime=d8' '--progress=buildbot' -v --reset-browser-configuration --report
--time --failure-summary --write-debug-log --write-test-outcome-log
--copy-coredumps --host-checked '--shards=5' '--shard=1'
'--exclude-suite=observatory_ui,co19'

   'analyze_library',
   'service',
   'kernel',
@@ -480,7 +479,7 @@ Note: currently only implemented for dart2js.''',
           'Exclude suites from default selector, only works when no'
           ' selector has been specified on the command line',
           ['--exclude-suite'],
-          defaultTestSelectors,
+          [],
           null),
       new _TestOptionSpecification(
           'skip-compilation',
@@ -735,7 +734,7 @@ Note: currently only implemented for dart2js.''',
     }
     if (config['ie'] && Platform.operatingSystem != 'windows') {
       isValid = false;
-      print("Warning cannot run Internet Explorer on non-Windows operating"
+      print("Warning: cannot run Internet Explorer on non-Windows operating"
           " system.");
     }
     if (config['shard'] < 1 || config['shard'] > config['shards']) {
@@ -820,8 +819,7 @@ Note: currently only implemented for dart2js.''',
           if (selectors.contains(exclude)) {
             selectors.remove(exclude);
           } else {
-            print("Error: default selectors does not contain $exclude");
-            exit(1);
+            print("Warning: default selectors does not contain $exclude");
           }
         }
       }