Remove 'pkg' from the default list of test suites

tools/testing/dart/test_options.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test_options_parser;
 
 import "dart:io";
 import "drt_updater.dart";
 import "test_suite.dart";
 import "path.dart";
 import "compiler_configuration.dart" show CompilerConfiguration;
 import "runtime_configuration.dart" show RuntimeConfiguration;
 
 const List<String> defaultTestSelectors = const [
   'samples',
   'standalone',
   'corelib',
   'co19',
   'language',
   'isolate',
   'vm',
   'html',
   'benchmark_smoke',
   'utils',
   'lib',
-  'pkg',

[kustermann, 2017/01/04 17:33:40]

We need to be careful here. I'm asking for pkg to be removed when we run vm (or
precompilation) tests. This is fine, because our buildbot explicitly passes
--exclude-suite=pkg.

BUT: There are other (non-vm) bots which actually do run 'pkg' (don't pass
--exclude-suite=pkg). For example:


python -u
/b/build/slave/dart2js-linux-d8-hostchecked-1-5-be/build/sdk/tools/test.py
'--mode=release' '--arch=ia32' '--compiler=dart2js' --dart2js-batch
'--runtime=d8' '--progress=buildbot' -v --reset-browser-configuration --report
--time --failure-summary --write-debug-log --write-test-outcome-log
--copy-coredumps --host-checked '--shards=5' '--shard=1'
'--exclude-suite=observatory_ui,co19'

   'analyze_library',
   'service',
   'kernel',
   'observatory_ui'
 ];
 
 /**
  * Specification of a single test option.
  *
  * The name of the specification is used as the key for the option in
@@ skipping 436 matching lines @@
           'packages',
           'The package spec file to use for testing.',
           ['--packages'],
           [],
           null),
       new _TestOptionSpecification(
           'exclude_suite',
           'Exclude suites from default selector, only works when no'
           ' selector has been specified on the command line',
           ['--exclude-suite'],
-          defaultTestSelectors,
+          [],
           null),
       new _TestOptionSpecification(
           'skip-compilation',
           'Skip the compilation step, using the compilation artifacts left in '
           ' the output folder from a previous run.'
           'This flag will often cause false positves and negatives, but can be'
           ' useful for quick-and-dirty offline testing when not making changes'
           ' that affect the compiler.',
           ['--skip-compilation'],
           [],
@@ skipping 234 matching lines @@
         break;
     }
     if (!validRuntimes.contains(config['runtime'])) {
       isValid = false;
       print("Warning: combination of compiler '${config['compiler']}' and "
           "runtime '${config['runtime']}' is invalid. "
           "Skipping this combination.");
     }
     if (config['ie'] && Platform.operatingSystem != 'windows') {
       isValid = false;
-      print("Warning cannot run Internet Explorer on non-Windows operating"
+      print("Warning: cannot run Internet Explorer on non-Windows operating"
           " system.");
     }
     if (config['shard'] < 1 || config['shard'] > config['shards']) {
       isValid = false;
       print("Error: shard index is ${config['shard']} out of "
           "${config['shards']} shards");
     }
 
     if (config['use_repository_packages'] && config['use_public_packages']) {
       isValid = false;
@@ skipping 64 matching lines @@
           selectors = new List.from(defaultTestSelectors);
         }
 
         var exclude_suites = configuration['exclude_suite'] != null
             ? configuration['exclude_suite'].split(',')
             : [];
         for (var exclude in exclude_suites) {
           if (selectors.contains(exclude)) {
             selectors.remove(exclude);
           } else {
-            print("Error: default selectors does not contain $exclude");
-            exit(1);
+            print("Warning: default selectors does not contain $exclude");
           }
         }
       }
       Map<String, RegExp> selectorMap = new Map<String, RegExp>();
       for (var i = 0; i < selectors.length; i++) {
         var pattern = selectors[i];
         var suite = pattern;
         var slashLocation = pattern.indexOf('/');
         if (slashLocation != -1) {
           suite = pattern.substring(0, slashLocation);
@@ skipping 166 matching lines @@
       if (option.keys.contains(name)) {
         return option;
       }
     }
     print('Unknown test option $name');
     exit(1);
   }
 
   List<_TestOptionSpecification> _options;
 }