Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 2610923011: Mark foreign-fetch-basics and foreign-fetch-cors tests as slow on windows. (Closed)

Created:
3 years, 11 months ago by Marijn Kruisselbrink
Modified:
3 years, 11 months ago
Reviewers:
jsbell
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark foreign-fetch-basics and foreign-fetch-cors tests as slow on windows. Hopefully these tests are indeed just sometimes extra slow (at least a 6x slowdown). If not I'll have to do more digging to see why they sometimes timeout. BUG=678498 BUG=678496 Review-Url: https://codereview.chromium.org/2610923011 Cr-Commit-Position: refs/heads/master@{#442100} Committed: https://chromium.googlesource.com/chromium/src/+/349d304bdcd2747ab6ec7efb35b502180e53aecb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/SlowTests View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Marijn Kruisselbrink
Not sure if these tests are actually just super-slow sometimes, or if something more serious ...
3 years, 11 months ago (2017-01-06 20:05:38 UTC) #8
jsbell
lgtm
3 years, 11 months ago (2017-01-06 23:39:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610923011/20001
3 years, 11 months ago (2017-01-06 23:49:13 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 23:55:13 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/349d304bdcd2747ab6ec7efb35b5...

Powered by Google App Engine
This is Rietveld 408576698