Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2610923010: Test accessibility of Reading List (Closed)

Created:
3 years, 11 months ago by gambard
Modified:
3 years, 11 months ago
Reviewers:
Olivier
CC:
chromium-reviews, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test accessibility of Reading List BUG=none Review-Url: https://codereview.chromium.org/2610923010 Cr-Commit-Position: refs/heads/master@{#441910} Committed: https://chromium.googlesource.com/chromium/src/+/78b9be0cd4da61618c21e4003f7cc84092684ccd

Patch Set 1 #

Total comments: 2

Patch Set 2 : Test accessibility out of edit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M ios/chrome/browser/ui/reading_list/reading_list_egtest.mm View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
gambard
PTAL.
3 years, 11 months ago (2017-01-06 09:35:10 UTC) #2
Olivier
LGTM one question https://codereview.chromium.org/2610923010/diff/1/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm File ios/chrome/browser/ui/reading_list/reading_list_egtest.mm (right): https://codereview.chromium.org/2610923010/diff/1/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm#newcode184 ios/chrome/browser/ui/reading_list/reading_list_egtest.mm:184: AddEntriesAndEnterEdit(); Should we test out of ...
3 years, 11 months ago (2017-01-06 09:44:41 UTC) #3
gambard
Thanks. https://codereview.chromium.org/2610923010/diff/1/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm File ios/chrome/browser/ui/reading_list/reading_list_egtest.mm (right): https://codereview.chromium.org/2610923010/diff/1/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm#newcode184 ios/chrome/browser/ui/reading_list/reading_list_egtest.mm:184: AddEntriesAndEnterEdit(); On 2017/01/06 09:44:41, Olivier Robin wrote: > ...
3 years, 11 months ago (2017-01-06 09:51:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610923010/20001
3 years, 11 months ago (2017-01-06 09:52:09 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 10:00:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/78b9be0cd4da61618c21e4003f7c...

Powered by Google App Engine
This is Rietveld 408576698