Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: ios/chrome/browser/ui/side_swipe/side_swipe_navigation_view.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/side_swipe/side_swipe_navigation_view.mm
diff --git a/ios/chrome/browser/ui/side_swipe/side_swipe_navigation_view.mm b/ios/chrome/browser/ui/side_swipe/side_swipe_navigation_view.mm
index 24dbefc133527e548c280c500346c74102ad9402..e558e781b17d6aa8e45cf23ddf2afc176886388c 100644
--- a/ios/chrome/browser/ui/side_swipe/side_swipe_navigation_view.mm
+++ b/ios/chrome/browser/ui/side_swipe/side_swipe_navigation_view.mm
@@ -7,7 +7,7 @@
#include <cmath>
#include "base/logging.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "base/metrics/user_metrics.h"
#include "base/metrics/user_metrics_action.h"
@@ -80,8 +80,6 @@ const CGFloat kSelectionAnimationDuration = 0.5;
// If |YES| arrowView_ is directionnal and must be rotated 180 degreed for the
// forward panes.
BOOL rotateForward_;
-
- base::mac::ObjCPropertyReleaser _propertyReleaser_SideSwipeNavigationView;
}
// Returns a newly allocated and configured selection circle shape.
- (CAShapeLayer*)newSelectionCircleLayer;
@@ -101,8 +99,6 @@ const CGFloat kSelectionAnimationDuration = 0.5;
rotateForward:(BOOL)rotateForward {
self = [super initWithFrame:frame];
if (self) {
- _propertyReleaser_SideSwipeNavigationView.Init(
- self, [SideSwipeNavigationView class]);
self.backgroundColor = [UIColor colorWithWhite:90.0 / 256 alpha:1.0];
canNavigate_ = canNavigate;
@@ -140,6 +136,11 @@ const CGFloat kSelectionAnimationDuration = 0.5;
return self;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (CGPoint)adjustPointToEdge:(CGPoint)currentPoint {
CGFloat width = CGRectGetWidth(self.targetView.bounds);
CGFloat half = floor(width / 2);

Powered by Google App Engine
This is Rietveld 408576698