Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: ios/chrome/browser/ui/page_not_available_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/page_not_available_controller.mm
diff --git a/ios/chrome/browser/ui/page_not_available_controller.mm b/ios/chrome/browser/ui/page_not_available_controller.mm
index b655777baa0a726729aa3b503770e527e2d5cb01..cf8fcf24d28e568b3e22731cb853ef3cb7d6c750 100644
--- a/ios/chrome/browser/ui/page_not_available_controller.mm
+++ b/ios/chrome/browser/ui/page_not_available_controller.mm
@@ -6,7 +6,7 @@
#include "base/i18n/rtl.h"
#include "base/logging.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "base/strings/sys_string_conversions.h"
#include "base/strings/utf_string_conversions.h"
@@ -32,9 +32,7 @@ const CGFloat kTitleLabelFontSize = 18.0;
const CGFloat kDescriptionViewFontSize = 17.0;
}
-@interface PageNotAvailableController () {
- base::mac::ObjCPropertyReleaser _propertyReleaser_PageNotAvailableController;
-}
+@interface PageNotAvailableController ()
// The title label displayed centered at the top of the screen.
@property(nonatomic, retain) UILabel* titleLabel;
@@ -53,9 +51,6 @@ const CGFloat kDescriptionViewFontSize = 17.0;
- (instancetype)initWithUrl:(const GURL&)url {
self = [super initWithNibName:nil url:url];
if (self) {
- _propertyReleaser_PageNotAvailableController.Init(
- self, [PageNotAvailableController class]);
-
// Use the host as the page title, unless the URL has a custom scheme.
if (self.url.SchemeIsHTTPOrHTTPS()) {
self.title = base::SysUTF16ToNSString(
@@ -116,6 +111,11 @@ const CGFloat kDescriptionViewFontSize = 17.0;
return self;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (instancetype)initWithNibName:(NSString*)nibName
url:(const GURL&)url NS_UNAVAILABLE {
NOTREACHED();

Powered by Google App Engine
This is Rietveld 408576698