ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm - Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)

Patch Set: weak -> assign Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/chrome/browser/ui/ntp/new_tab_page_view.h ('K') | « ios/chrome/browser/ui/open_in_controller.mm ('k') | ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

diff --git a/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm b/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

index fb7d43df1ad4d4a9b638fcf3ad16102db4404501..f9e03938e4a1924eb8785342cda831fee84d59e7 100644

--- a/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

+++ b/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

@@ -8,7 +8,7 @@

#include <algorithm>

#include "base/logging.h"

-#include "base/mac/objc_property_releaser.h"

+#include "base/mac/objc_release_properties.h"

#include "base/mac/scoped_nsobject.h"

#include "base/metrics/histogram.h"

#import "ios/chrome/browser/ui/browser_view_controller.h"

@@ -163,7 +163,6 @@ NSString* const kOverscrollActionsDidEnd = @"OverscrollActionsDidStop";

// The scrollview driving the OverscrollActionsController when not using

// the scrollview from the CRWWebControllerObserver.

base::scoped_nsobject<UIScrollView> _scrollview;

- base::mac::ObjCPropertyReleaser _propertyReleaser_OverscrollActionsController;

}

// The view displayed over the header view holding the actions.

@@ -241,8 +240,6 @@ NSString* const kOverscrollActionsDidEnd = @"OverscrollActionsDidStop";

- (instancetype)initWithScrollView:(UIScrollView*)scrollView {

self = [super init];

if (self) {

- _propertyReleaser_OverscrollActionsController.Init(

- self, [OverscrollActionsController class]);

_overscrollActionView =

[[OverscrollActionsView alloc] initWithFrame:CGRectZero];

_overscrollActionView.delegate = self;

@@ -275,6 +272,7 @@ NSString* const kOverscrollActionsDidEnd = @"OverscrollActionsDidStop";

- (void)dealloc {

self.overscrollActionView.delegate = nil;

[self invalidate];

+ base::mac::ReleaseProperties(self);

[super dealloc];

}