Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: ios/chrome/browser/ui/omnibox/page_info_view_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/omnibox/page_info_view_controller.mm
diff --git a/ios/chrome/browser/ui/omnibox/page_info_view_controller.mm b/ios/chrome/browser/ui/omnibox/page_info_view_controller.mm
index 78fb2a5a7b825d9bb004acf85b47c11bf6fdea45..8f655276bb27c9e770a02e9f0ef89900194321e9 100644
--- a/ios/chrome/browser/ui/omnibox/page_info_view_controller.mm
+++ b/ios/chrome/browser/ui/omnibox/page_info_view_controller.mm
@@ -8,7 +8,7 @@
#include "base/location.h"
#include "base/mac/bundle_locations.h"
#import "base/mac/foundation_util.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "base/message_loop/message_loop.h"
#include "base/single_thread_task_runner.h"
@@ -151,8 +151,6 @@ void PageInfoModelBubbleBridge::OnPageInfoModelChanged() {
// YES when the popup has finished animating in. NO otherwise.
BOOL animateInCompleted_;
-
- base::mac::ObjCPropertyReleaser propertyReleaser_PageInfoViewController_;
}
// Adds the state image at a pre-determined x position and the given y. This
@@ -199,9 +197,6 @@ void PageInfoModelBubbleBridge::OnPageInfoModelChanged() {
DCHECK(parent);
self = [super init];
if (self) {
- propertyReleaser_PageInfoViewController_.Init(
- self, [PageInfoViewController class]);
-
scrollView_.reset(
[[UIScrollView alloc] initWithFrame:CGRectMake(0, 0, 240, 128)]);
[scrollView_ setMultipleTouchEnabled:YES];
@@ -272,6 +267,11 @@ void PageInfoModelBubbleBridge::OnPageInfoModelChanged() {
return self;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (void)performLayout {
CGFloat offset = kInitialLinePadding;

Powered by Google App Engine
This is Rietveld 408576698