Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: ios/chrome/browser/ui/history/favicon_view_provider.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/history/favicon_view_provider.mm
diff --git a/ios/chrome/browser/ui/history/favicon_view_provider.mm b/ios/chrome/browser/ui/history/favicon_view_provider.mm
index ea2707e9dc595e037eb94c733d0e08dfde6520f1..0eaaac261d2f81e15c2b8fd110dd6d8c3f24dda7 100644
--- a/ios/chrome/browser/ui/history/favicon_view_provider.mm
+++ b/ios/chrome/browser/ui/history/favicon_view_provider.mm
@@ -8,7 +8,7 @@
#include "base/ios/weak_nsobject.h"
#include "base/mac/bind_objc_block.h"
#import "base/mac/foundation_util.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "base/memory/ref_counted_memory.h"
#include "base/strings/sys_string_conversions.h"
@@ -25,8 +25,6 @@
#include "url/gurl.h"
@interface FaviconViewProvider () {
- // Property releaser for FaviconViewProvider.
- base::mac::ObjCPropertyReleaser _propertyReleaser_FaviconViewProvider;
// Delegate for handling completion of favicon load.
base::WeakNSProtocol<id<FaviconViewProviderDelegate>> _delegate;
// Used to cancel tasks for the LargeIconService.
@@ -73,8 +71,6 @@
delegate:(id<FaviconViewProviderDelegate>)delegate {
self = [super init];
if (self) {
- _propertyReleaser_FaviconViewProvider.Init(self,
- [FaviconViewProvider class]);
_faviconSize = faviconSize;
_delegate.reset(delegate);
_fallbackBackgroundColor = [[UIColor grayColor] retain];
@@ -92,6 +88,11 @@
return nil;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (void)fetchFaviconForURL:(const GURL&)URL
size:(CGFloat)size
minSize:(CGFloat)minSize

Powered by Google App Engine
This is Rietveld 408576698