Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: ios/chrome/browser/ui/history/favicon_view.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/history/favicon_view.mm
diff --git a/ios/chrome/browser/ui/history/favicon_view.mm b/ios/chrome/browser/ui/history/favicon_view.mm
index bef1d0ef5f5b5ba983694017655961dacc70b877..fc491845654e48de251de69149409152ec5a60bd 100644
--- a/ios/chrome/browser/ui/history/favicon_view.mm
+++ b/ios/chrome/browser/ui/history/favicon_view.mm
@@ -4,7 +4,7 @@
#import "ios/chrome/browser/ui/history/favicon_view.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#import "ios/chrome/browser/ui/uikit_ui_util.h"
namespace {
@@ -12,10 +12,7 @@ namespace {
const CGFloat kDefaultCornerRadius = 3;
}
-@interface FaviconView () {
- // Property releaser for FaviconView.
- base::mac::ObjCPropertyReleaser _propertyReleaser_FaviconView;
-}
+@interface FaviconView ()
// Size constraints for the favicon views.
@property(nonatomic, copy) NSArray* faviconSizeConstraints;
@end
@@ -30,7 +27,6 @@ const CGFloat kDefaultCornerRadius = 3;
- (instancetype)initWithFrame:(CGRect)frame {
self = [super initWithFrame:frame];
if (self) {
- _propertyReleaser_FaviconView.Init(self, [FaviconView class]);
_faviconImage = [[UIImageView alloc] init];
_faviconImage.clipsToBounds = YES;
_faviconImage.layer.cornerRadius = kDefaultCornerRadius;
@@ -60,6 +56,11 @@ const CGFloat kDefaultCornerRadius = 3;
return self;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (void)setSize:(CGFloat)size {
_size = size;
for (NSLayoutConstraint* constraint in self.faviconSizeConstraints) {

Powered by Google App Engine
This is Rietveld 408576698