Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index 663810736aade11d923e3ecf04676f57e366edd0..6c8a15ea60c4044a6c038a7b9726e5fe467d57be 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -25,7 +25,7 @@
#include "base/mac/bind_objc_block.h"
#include "base/mac/bundle_locations.h"
#include "base/mac/foundation_util.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#import "base/mac/scoped_block.h"
#import "base/mac/scoped_nsobject.h"
#include "base/macros.h"
@@ -483,9 +483,6 @@ NSString* const kReadingListSnackbarCategory = @"ReadingListSnackbarCategory";
// Coordinator for displaying alerts.
base::scoped_nsobject<AlertCoordinator> _alertCoordinator;
-
- // Releaser for properties that aren't backed by scoped_nsobjects.
- base::mac::ObjCPropertyReleaser _propertyReleaser_BrowserViewController;
}
// The browser's side swipe controller. Lazily instantiated on the first call.
@@ -900,8 +897,6 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
self = [super initWithNibName:nil bundle:base::mac::FrameworkBundle()];
if (self) {
DCHECK(factory);
- _propertyReleaser_BrowserViewController.Init(self,
- [BrowserViewController class]);
_imageFetcher = base::MakeUnique<web::ImageDataFetcher>(
web::WebThread::GetBlockingPool());
_dependencyFactory.reset([factory retain]);
@@ -951,6 +946,7 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
_voiceSearchController->SetDelegate(nil);
[_rateThisAppDialog setDelegate:nil];
[_model closeAllTabs];
+ base::mac::ReleaseProperties(self);
[super dealloc];
}

Powered by Google App Engine
This is Rietveld 408576698