Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm b/ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm
index e2c031f3e05c34569ae180e8e7baa02dd34e9755..c748979a1690f7db045fae0659c2689a645c2eba 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm
@@ -7,7 +7,7 @@
#import <QuartzCore/QuartzCore.h>
#include "base/logging.h"
-#import "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#import "base/mac/scoped_nsobject.h"
#import "ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.h"
#import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h"
@@ -151,9 +151,7 @@ void SetTextWithLineHeight(UILabel* label, NSString* text, CGFloat lineHeight) {
@end
-@interface BookmarkPromoCell () {
- base::mac::ObjCPropertyReleaser _propertyReleaser_BookmarkPromoCell;
-}
+@interface BookmarkPromoCell ()
@property(nonatomic, assign) BookmarkPromoView* promoView;
@property(nonatomic, retain) NSArray* compactContentViewConstraints;
@property(nonatomic, retain) NSArray* regularContentViewConstraints;
@@ -177,7 +175,6 @@ void SetTextWithLineHeight(UILabel* label, NSString* text, CGFloat lineHeight) {
- (instancetype)initWithFrame:(CGRect)frame {
self = [super initWithFrame:frame];
if (self) {
- _propertyReleaser_BookmarkPromoCell.Init(self, [BookmarkPromoCell class]);
self.contentView.translatesAutoresizingMaskIntoConstraints = NO;
_promoView = [[[BookmarkPromoView alloc] initWithFrame:frame] autorelease];
@@ -194,6 +191,11 @@ void SetTextWithLineHeight(UILabel* label, NSString* text, CGFloat lineHeight) {
return self;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (void)traitCollectionDidChange:(UITraitCollection*)previousTraitCollection {
[self updatePromoView];
}

Powered by Google App Engine
This is Rietveld 408576698