Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm b/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm
index 1c01fe309b6d0f33f8d3f5b70d5761913c1ff796..8abfec7a7459ae2e4e47eaf610bb02cb9418d1d2 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm
@@ -13,7 +13,7 @@
#include "base/logging.h"
#include "base/mac/bind_objc_block.h"
#import "base/mac/foundation_util.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_cftyperef.h"
#include "base/mac/scoped_nsobject.h"
#include "base/strings/sys_string_conversions.h"
@@ -78,8 +78,6 @@ typedef NS_ENUM(NSInteger, ItemType) {
BOOL _ignoresBookmarkModelChanges;
std::unique_ptr<bookmarks::BookmarkModelBridge> _modelBridge;
-
- base::mac::ObjCPropertyReleaser _propertyReleaser_BookmarkEditViewController;
}
// The bookmark this controller displays or edits.
@@ -168,8 +166,6 @@ typedef NS_ENUM(NSInteger, ItemType) {
DCHECK(browserState);
self = [super initWithStyle:CollectionViewControllerStyleAppBar];
if (self) {
- _propertyReleaser_BookmarkEditViewController.Init(
- self, [BookmarkEditViewController class]);
DCHECK(!bookmark->is_folder());
DCHECK(!browserState->IsOffTheRecord());
_bookmark = bookmark;
@@ -189,6 +185,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
- (void)dealloc {
_folderViewController.delegate = nil;
+ base::mac::ReleaseProperties(self);
[super dealloc];
}

Powered by Google App Engine
This is Rietveld 408576698