Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_collection_view_background.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bookmarks/bookmark_collection_view_background.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_collection_view_background.mm b/ios/chrome/browser/ui/bookmarks/bookmark_collection_view_background.mm
index f8974777bf1c538bbd11cf8563fbb5a98058d1f7..cab0709fbb24f9967d73c4c02f3f710d9da92679 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_collection_view_background.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_collection_view_background.mm
@@ -4,7 +4,7 @@
#include "ios/chrome/browser/ui/bookmarks/bookmark_collection_view_background.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#import "ios/third_party/material_roboto_font_loader_ios/src/src/MaterialRobotoFontLoader.h"
namespace {
@@ -14,10 +14,7 @@ const CGFloat kEmptyBookmarkTextSize = 16.0;
const CGFloat kImageViewOffsetFromText = 5.0;
} // namespace
-@interface BookmarkCollectionViewBackground () {
- base::mac::ObjCPropertyReleaser
- _propertyReleaser_BookmarkBookmarkCollectionViewBackground;
-}
+@interface BookmarkCollectionViewBackground ()
// Star image view shown on top of the label.
@property(nonatomic, retain) UIImageView* emptyBookmarksImageView;
@@ -34,8 +31,6 @@ const CGFloat kImageViewOffsetFromText = 5.0;
- (instancetype)initWithFrame:(CGRect)frame {
self = [super initWithFrame:frame];
if (self) {
- _propertyReleaser_BookmarkBookmarkCollectionViewBackground.Init(
- self, [BookmarkCollectionViewBackground class]);
_emptyBookmarksImageView = [self newBookmarkImageView];
[self addSubview:_emptyBookmarksImageView];
_emptyBookmarksLabel = [self newEmptyBookmarkLabel];
@@ -44,6 +39,11 @@ const CGFloat kImageViewOffsetFromText = 5.0;
return self;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (void)layoutSubviews {
[super layoutSubviews];
_emptyBookmarksLabel.frame = [self emptyBookmarkLabelFrame];

Powered by Google App Engine
This is Rietveld 408576698