Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: components/autofill/ios/browser/form_suggestion.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/ios/browser/form_suggestion.mm
diff --git a/components/autofill/ios/browser/form_suggestion.mm b/components/autofill/ios/browser/form_suggestion.mm
index f4bb40c37c3065eb921aceac76ee818042015683..36ca9d9fb7301b2d30af35327c08d6e481728b2b 100644
--- a/components/autofill/ios/browser/form_suggestion.mm
+++ b/components/autofill/ios/browser/form_suggestion.mm
@@ -4,7 +4,7 @@
#import "components/autofill/ios/browser/form_suggestion.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
@interface FormSuggestion ()
// Local initializer for a FormSuggestion.
@@ -14,14 +14,7 @@
identifier:(NSInteger)identifier;
@end
-@implementation FormSuggestion {
- NSString* _value;
- NSString* _displayDescription;
- NSString* _icon;
- NSInteger _identifier;
- base::mac::ObjCPropertyReleaser _propertyReleaser_FormSuggestion;
-}
-
+@implementation FormSuggestion
@synthesize value = _value;
@synthesize displayDescription = _displayDescription;
@synthesize icon = _icon;
@@ -33,7 +26,6 @@
identifier:(NSInteger)identifier {
self = [super init];
if (self) {
- _propertyReleaser_FormSuggestion.Init(self, [FormSuggestion class]);
_value = [value copy];
_displayDescription = [displayDescription copy];
_icon = [icon copy];
@@ -42,6 +34,11 @@
return self;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
+ (FormSuggestion*)suggestionWithValue:(NSString*)value
displayDescription:(NSString*)displayDescription
icon:(NSString*)icon

Powered by Google App Engine
This is Rietveld 408576698