Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3047)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm
index 449e4f0075a8d94eb51fde4ff1e3fae1b46de0f8..53e92aecf3ccf5d8cfd32adde5eb0dd5deaadf7d 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm
@@ -11,7 +11,7 @@
#include "base/i18n/rtl.h"
#include "base/mac/foundation_util.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
@@ -343,11 +343,6 @@ NSAttributedString* CreateClassifiedAttributedString(
} // namespace
-@interface OmniboxPopupCellData () {
- base::mac::ObjCPropertyReleaser propertyReleaser_OmniboxPopupCellData_;
-}
-@end
-
@interface OmniboxPopupCell ()
- (CGFloat)drawMatchPart:(NSAttributedString*)attributedString
withFrame:(NSRect)cellFrame
@@ -418,12 +413,15 @@ NSAttributedString* CreateClassifiedAttributedString(
}
maxLines_ = 1;
}
- propertyReleaser_OmniboxPopupCellData_.Init(self,
- [OmniboxPopupCellData class]);
}
return self;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (instancetype)copyWithZone:(NSZone*)zone {
return [self retain];
}

Powered by Google App Engine
This is Rietveld 408576698