Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2610903002: Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] (Closed)

Created:
3 years, 11 months ago by riju_
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, tzik, nhiroki, jkarlin+watch_chromium.org, cmumford, blink-reviews, jsbell+idb_chromium.org, kinuko+fileapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] Affected dirs in this CL-> modules/netinfo modules/netinfo modules/beacon modules/indexeddb modules/filesystem modules/fetch BUG=670618 Review-Url: https://codereview.chromium.org/2610903002 Cr-Commit-Position: refs/heads/master@{#441630} Committed: https://chromium.googlesource.com/chromium/src/+/8cbdb95263b21246dac6c3726bc52961cd1213dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -88 lines) Patch
M third_party/WebKit/Source/modules/beacon/NavigatorBeacon.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/beacon/NavigatorBeacon.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/Entry.h View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/Entry.cpp View 2 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/Entry.idl View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/HTMLInputElementFileSystem.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/HTMLInputElementFileSystem.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/HTMLInputElementFileSystem.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBKeyRange.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBKeyRange.cpp View 6 chunks +17 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBKeyRange.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/netinfo/WorkerNavigatorNetworkInformation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/netinfo/WorkerNavigatorNetworkInformation.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/netinfo/WorkerNavigatorNetworkInformation.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechGrammarList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechGrammarList.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechGrammarList.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
riju_
Hi haraken, There are a few other places where [CallWith=ExecutionContext] can be replaced with [CallWith=ScriptState]. ...
3 years, 11 months ago (2017-01-05 11:30:41 UTC) #7
haraken
LGTM
3 years, 11 months ago (2017-01-05 11:33:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610903002/1
3 years, 11 months ago (2017-01-05 12:02:19 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 12:40:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8cbdb95263b21246dac6c3726bc5...

Powered by Google App Engine
This is Rietveld 408576698