Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2610893005: Migrate WTF::Vector::append() to ::push_back() [part 16 of N] (Closed)

Created:
3 years, 11 months ago by pilgrim_google
Modified:
3 years, 11 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::Vector::append() to ::push_back() [part 16 of N] As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. This CL replaces append() with push_back() in Source/build/scripts/templates/. There are too many references to change them all at once, so this CL is part 16 of many. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2610893005 Cr-Commit-Position: refs/heads/master@{#442260} Committed: https://chromium.googlesource.com/chromium/src/+/8b3d051c336e3b9c5a83d3187290b8eadeb7b438

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/CSSOMKeywords.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
pilgrim_google
3 years, 11 months ago (2017-01-06 14:46:32 UTC) #4
haraken
LGTM
3 years, 11 months ago (2017-01-06 14:47:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610893005/20001
3 years, 11 months ago (2017-01-09 15:02:13 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 16:22:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8b3d051c336e3b9c5a83d3187290...

Powered by Google App Engine
This is Rietveld 408576698