Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2610893004: [Media] Disable background video optimization for streaming videos (Closed)

Created:
3 years, 11 months ago by whywhat
Modified:
3 years, 11 months ago
CC:
apacible+watch_chromium.org, chromium-reviews, erickung+watch_chromium.org, feature-media-reviews_chromium.org, miu+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media] Disable background video optimization for streaming videos BUG=675282 TEST=manual Review-Url: https://codereview.chromium.org/2610893004 Cr-Commit-Position: refs/heads/master@{#442147} Committed: https://chromium.googlesource.com/chromium/src/+/102cdb66b3460080b67f5e27e2d7db9fc206c564

Patch Set 1 #

Patch Set 2 : Check for infinite duration #

Total comments: 2

Patch Set 3 : Removed the duration check for now #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M media/blink/webmediaplayer_impl.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 2 3 5 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
whywhat
PTaL Should I also check for duration == infinity for MSE as Sergey suggests?
3 years, 11 months ago (2017-01-05 23:36:11 UTC) #2
sandersd (OOO until July 31)
LGTM. > Should I also check for duration == infinity for MSE as Sergey suggests? ...
3 years, 11 months ago (2017-01-05 23:51:15 UTC) #3
whywhat
Check for infinite duration
3 years, 11 months ago (2017-01-06 02:14:54 UTC) #4
whywhat
Added a check for duration but didn't find a good example in the wild: cnn/fox ...
3 years, 11 months ago (2017-01-06 02:19:01 UTC) #5
sandersd (OOO until July 31)
https://codereview.chromium.org/2610893004/diff/20001/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/2610893004/diff/20001/media/blink/webmediaplayer_impl.cc#newcode2034 media/blink/webmediaplayer_impl.cc:2034: return !std::isfinite(duration()) || FYI: I was just looking through ...
3 years, 11 months ago (2017-01-06 21:20:28 UTC) #6
whywhat
https://codereview.chromium.org/2610893004/diff/20001/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/2610893004/diff/20001/media/blink/webmediaplayer_impl.cc#newcode2034 media/blink/webmediaplayer_impl.cc:2034: return !std::isfinite(duration()) || On 2017/01/06 at 21:20:28, sandersd wrote: ...
3 years, 11 months ago (2017-01-06 22:19:57 UTC) #7
sandersd (OOO until July 31)
> Hm, liveness seems to depend on the stream parser: > - ffmpeg checks for ...
3 years, 11 months ago (2017-01-06 22:23:55 UTC) #8
whywhat
Removed the duration check for now
3 years, 11 months ago (2017-01-06 22:33:36 UTC) #9
whywhat
Rebase
3 years, 11 months ago (2017-01-07 01:04:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610893004/60001
3 years, 11 months ago (2017-01-07 01:25:55 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 03:11:43 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/102cdb66b3460080b67f5e27e2d7...

Powered by Google App Engine
This is Rietveld 408576698