[Media] Disable background video optimization for streaming videos

[Media] Disable background video optimization for streaming videos

BUG=675282
TEST=manual

Review-Url: https://codereview.chromium.org/2610893004
Cr-Commit-Position: refs/heads/master@{#442147}
Committed: https://chromium.googlesource.com/chromium/src/+/102cdb66b3460080b67f5e27e2d7db9fc206c564

[whywhat, 2017-01-05 23:36:11]

avayvod@chromium.org changed reviewers:
+ sandersd@chromium.org

[whywhat, 2017-01-05 23:36:11]

PTaL

Should I also check for duration == infinity for MSE as Sergey suggests?

[sandersd (OOO until July 31), 2017-01-05 23:51:15]

LGTM.

> Should I also check for duration == infinity for MSE as Sergey suggests?

It's hard to say, I can't predict exactly what the kinds of problems MSE may
encounter are.

It probably won't hurt much to add that restriction. Certainly it could hurt to
try to add the track again when where is no keyframe in the buffer, but that is
plausible for non-streaming media as well.

I would say add that restriction now, and follow up with Matt about the best
possible implementation.

[whywhat, 2017-01-06 02:14:54]

Check for infinite duration

[whywhat, 2017-01-06 02:19:01]

Added a check for duration but didn't find a good example in the wild: cnn/fox
news failed to decode and used a URL on mobile while Youtube Live channel
reports duration for the videos (e.g. 3600 for the top eagle nest one -- we
don't detect it as streaming).

[sandersd (OOO until July 31), 2017-01-06 21:20:28]

https://codereview.chromium.org/2610893004/diff/20001/media/blink/webmediapla...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2610893004/diff/20001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:2034: return !std::isfinite(duration()) ||
FYI: I was just looking through this code, and everything else is using
video_stream->liveness(). This is the bit that enables low-delay decoding, so
it's worth verifying that the computation is the same.

[whywhat, 2017-01-06 22:19:57]

https://codereview.chromium.org/2610893004/diff/20001/media/blink/webmediapla...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2610893004/diff/20001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:2034: return !std::isfinite(duration()) ||
On 2017/01/06 at 21:20:28, sandersd wrote:
> FYI: I was just looking through this code, and everything else is using
video_stream->liveness(). This is the bit that enables low-delay decoding, so
it's worth verifying that the computation is the same.

Hm, liveness seems to depend on the stream parser:
- ffmpeg checks for duration to be infinite:
https://cs.chromium.org/chromium/src/media/formats/webm/webm_stream_parser.cc...
- chunk (webm stream?) checks for negative duration:
https://cs.chromium.org/chromium/src/media/formats/webm/webm_stream_parser.cc...

I'm happy to use that but need to find a way to propagate it from demuxer stream
to WMPI

[sandersd (OOO until July 31), 2017-01-06 22:23:55]

> Hm, liveness seems to depend on the stream parser:
> - ffmpeg checks for duration to be infinite:
>
https://cs.chromium.org/chromium/src/media/formats/webm/webm_stream_parser.cc...
> - chunk (webm stream?) checks for negative duration:
>
https://cs.chromium.org/chromium/src/media/formats/webm/webm_stream_parser.cc...
> 
> I'm happy to use that but need to find a way to propagate it from demuxer
stream
> to WMPI

It might be best then to explicitly check for MSE and use the duration check,
otherwise use the data source check. (Using only the data source check is
correct for src=)

Or take the easy route and skip the duration check entirely; worry about this
once Matt has had a chance to weigh in.

[whywhat, 2017-01-06 22:33:36]

Removed the duration check for now

[whywhat, 2017-01-06 22:34:16]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 22:35:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 00:10:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 00:10:45]

Dry run: This issue passed the CQ dry run.

[whywhat, 2017-01-07 01:04:05]

Rebase

[whywhat, 2017-01-07 01:25:37]

The CQ bit was checked by avayvod@chromium.org

[whywhat, 2017-01-07 01:25:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/2610893004/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-07 01:25:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 03:11:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483752337269630,
"parent_rev": "f57f9f5b9caa535c152fcc7b2b4622ab5fb3805a", "commit_rev":
"102cdb66b3460080b67f5e27e2d7db9fc206c564"}

[commit-bot: I haz the power, 2017-01-07 03:11:42]

Description was changed from

==========
[Media] Disable background video optimization for streaming videos

BUG=675282
TEST=manual
==========

to

==========
[Media] Disable background video optimization for streaming videos

BUG=675282
TEST=manual

Review-Url: https://codereview.chromium.org/2610893004
Cr-Commit-Position: refs/heads/master@{#442147}
Committed:
https://chromium.googlesource.com/chromium/src/+/102cdb66b3460080b67f5e27e2d7...
==========

[commit-bot: I haz the power, 2017-01-07 03:11:43]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/102cdb66b3460080b67f5e27e2d7...