|
|
DescriptionImplements CSSPropertyAPI for the stroke-dasharray property.
A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyStrokeDasharray from the switch statement in
parseSingleValue, and calls the API instead.
A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.
This patch:
- Adds CSSPropertyAPIStrokeDasharray.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
CSSPropertyAPIStrokeDasharray.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
CSSPropertyAPIStrokeDasharray.cpp, which implements CSSPropertyAPI.h.
BUG=668012
Review-Url: https://codereview.chromium.org/2610893003
Cr-Commit-Position: refs/heads/master@{#443968}
Committed: https://chromium.googlesource.com/chromium/src/+/9c405967c3d7410c1e07cbc68314acb1ea6015a2
Patch Set 1 #Patch Set 2 : fixed dependencies, changed year #Patch Set 3 : dependencies #
Total comments: 1
Patch Set 4 : rebase #Patch Set 5 : fixed dependency #Patch Set 6 : rebase #Patch Set 7 : rbease #Patch Set 8 : changed reference to pointer #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 54 (48 generated)
aazzam@google.com changed reviewers: + alancutter@chromium.org
lgtm
Description was changed from ========== Implemented CSSPropertyAPI for stroke-dasharray property. Added CSSPropertyAPIStrokeDasharray which implements CSSPropertyAPI for the stroke-dasharray property. Moved parsing logic from CSSPropertyParser to the .cpp file. Added flag to CSSProperties.in so that the .h file will be generated. BUG=668012 ========== to ========== Implemented CSSPropertyAPI for stroke-dasharray property. Added CSSPropertyAPIStrokeDasharray which implements CSSPropertyAPI for the stroke-dasharray property. Parsing logic is the same as before, just was moved from CSSPropertyParser to the .cpp file. Added flag to CSSProperties.in so that the .h file will be generated. BUG=668012 ==========
aazzam@google.com changed reviewers: + sashab@chromium.org
sashab rs lgtm please :)
lgtm https://codereview.chromium.org/2610893003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIStrokeDasharray.cpp (right): https://codereview.chromium.org/2610893003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/css/properties/CSSPropertyAPIStrokeDasharray.cpp:7: #include "core/css/CSSValueList.h" Add CSSPrimitiveValue please :)
Description was changed from ========== Implemented CSSPropertyAPI for stroke-dasharray property. Added CSSPropertyAPIStrokeDasharray which implements CSSPropertyAPI for the stroke-dasharray property. Parsing logic is the same as before, just was moved from CSSPropertyParser to the .cpp file. Added flag to CSSProperties.in so that the .h file will be generated. BUG=668012 ========== to ========== Implemented CSSPropertyAPI for the stroke-dasharray property. A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyStrokeDasharray from the switch statement in parseSingleValue, and calls the API instead. A function pointer to the parseSingleValue function from the API for the page property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. This patch: - Adds CSSPropertyAPIStrokeDasharray.cpp to the BUILD.gn file. - Adds api_class flag to CSSProperties.in, which indicates that CSSPropertyAPIStrokeDasharray.h is generated. - Moves the parsing logic for page from CSSPropertyParser.cpp to CSSPropertyAPIStrokeDasharray.cpp, which implements CSSPropertyAPI.h. BUG=668012 ==========
Description was changed from ========== Implemented CSSPropertyAPI for the stroke-dasharray property. A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyStrokeDasharray from the switch statement in parseSingleValue, and calls the API instead. A function pointer to the parseSingleValue function from the API for the page property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. This patch: - Adds CSSPropertyAPIStrokeDasharray.cpp to the BUILD.gn file. - Adds api_class flag to CSSProperties.in, which indicates that CSSPropertyAPIStrokeDasharray.h is generated. - Moves the parsing logic for page from CSSPropertyParser.cpp to CSSPropertyAPIStrokeDasharray.cpp, which implements CSSPropertyAPI.h. BUG=668012 ========== to ========== Implements CSSPropertyAPI for the stroke-dasharray property. A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyStrokeDasharray from the switch statement in parseSingleValue, and calls the API instead. A function pointer to the parseSingleValue function from the API for the page property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. This patch: - Adds CSSPropertyAPIStrokeDasharray.cpp to the BUILD.gn file. - Adds api_class flag to CSSProperties.in, which indicates that CSSPropertyAPIStrokeDasharray.h is generated. - Moves the parsing logic for page from CSSPropertyParser.cpp to CSSPropertyAPIStrokeDasharray.cpp, which implements CSSPropertyAPI.h. BUG=668012 ==========
The CQ bit was checked by aazzam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by aazzam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by aazzam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by aazzam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by aazzam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Exceeded global retry quota
The CQ bit was checked by aazzam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by aazzam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by aazzam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by aazzam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by aazzam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by aazzam@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from alancutter@chromium.org, sashab@chromium.org Link to the patchset: https://codereview.chromium.org/2610893003/#ps140001 (title: "changed reference to pointer")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 140001, "attempt_start_ts": 1484617675869210, "parent_rev": "5f39f7da67a92e9b7009c13d3536394f0981c13c", "commit_rev": "9c405967c3d7410c1e07cbc68314acb1ea6015a2"}
Message was sent while issue was closed.
Description was changed from ========== Implements CSSPropertyAPI for the stroke-dasharray property. A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyStrokeDasharray from the switch statement in parseSingleValue, and calls the API instead. A function pointer to the parseSingleValue function from the API for the page property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. This patch: - Adds CSSPropertyAPIStrokeDasharray.cpp to the BUILD.gn file. - Adds api_class flag to CSSProperties.in, which indicates that CSSPropertyAPIStrokeDasharray.h is generated. - Moves the parsing logic for page from CSSPropertyParser.cpp to CSSPropertyAPIStrokeDasharray.cpp, which implements CSSPropertyAPI.h. BUG=668012 ========== to ========== Implements CSSPropertyAPI for the stroke-dasharray property. A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyStrokeDasharray from the switch statement in parseSingleValue, and calls the API instead. A function pointer to the parseSingleValue function from the API for the page property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. This patch: - Adds CSSPropertyAPIStrokeDasharray.cpp to the BUILD.gn file. - Adds api_class flag to CSSProperties.in, which indicates that CSSPropertyAPIStrokeDasharray.h is generated. - Moves the parsing logic for page from CSSPropertyParser.cpp to CSSPropertyAPIStrokeDasharray.cpp, which implements CSSPropertyAPI.h. BUG=668012 Review-Url: https://codereview.chromium.org/2610893003 Cr-Commit-Position: refs/heads/master@{#443968} Committed: https://chromium.googlesource.com/chromium/src/+/9c405967c3d7410c1e07cbc68314... ==========
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as https://chromium.googlesource.com/chromium/src/+/9c405967c3d7410c1e07cbc68314... |