Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2610883004: Gtk3: Rename Gtk2UI and Get[FB]GColor (Closed)

Created:
3 years, 11 months ago by Tom (Use chromium acct)
Modified:
3 years, 11 months ago
Reviewers:
Elliot Glaysher, sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk3: Rename Gtk2UI and Get[FB]GColor This is a simple renaming CL. A global search/replace was done with the following strings: Gtk2UI -> GtkUi GetFGColor -> GetFgColor GetBGColor -> GetBgColor BUG=132847 Committed: https://crrev.com/b1f498915edb2115c8f993e60e19728afda80acb Cr-Commit-Position: refs/heads/master@{#441559}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -152 lines) Patch
M chrome/browser/themes/theme_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtkui/gconf_listener.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/libgtkui/gconf_listener.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_ui.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_ui.cc View 26 chunks +59 lines, -60 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk2.cc View 8 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk3.cc View 3 chunks +58 lines, -58 lines 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (13 generated)
Tom (Use chromium acct)
erg@ and sky@ PTAL erg: chrome/browser/ui/libgtkui/gconf_listener.cc chrome/browser/ui/libgtkui/gconf_listener.h chrome/browser/ui/libgtkui/gtk_ui.cc chrome/browser/ui/libgtkui/gtk_ui.h chrome/browser/ui/libgtkui/gtk_util.cc chrome/browser/ui/libgtkui/gtk_util.h chrome/browser/ui/libgtkui/native_theme_gtk2.cc chrome/browser/ui/libgtkui/native_theme_gtk3.cc sky: chrome/browser/themes/theme_service.cc ...
3 years, 11 months ago (2017-01-05 00:06:01 UTC) #1
Tom (Use chromium acct)
erg@ and sky@ PTAL erg: chrome/browser/ui/libgtkui/gconf_listener.cc chrome/browser/ui/libgtkui/gconf_listener.h chrome/browser/ui/libgtkui/gtk_ui.cc chrome/browser/ui/libgtkui/gtk_ui.h chrome/browser/ui/libgtkui/gtk_util.cc chrome/browser/ui/libgtkui/gtk_util.h chrome/browser/ui/libgtkui/native_theme_gtk2.cc chrome/browser/ui/libgtkui/native_theme_gtk3.cc sky: chrome/browser/themes/theme_service.cc ...
3 years, 11 months ago (2017-01-05 00:06:28 UTC) #3
Elliot Glaysher
lgtm
3 years, 11 months ago (2017-01-05 00:21:22 UTC) #4
sky
LGTM
3 years, 11 months ago (2017-01-05 00:39:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610883004/1
3 years, 11 months ago (2017-01-05 00:41:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/130312) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-05 00:43:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610883004/20001
3 years, 11 months ago (2017-01-05 02:12:11 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-05 02:17:29 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 02:20:07 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b1f498915edb2115c8f993e60e19728afda80acb
Cr-Commit-Position: refs/heads/master@{#441559}

Powered by Google App Engine
This is Rietveld 408576698